fix(ci): properly check image build status#21789
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
kalverra
approved these changes
Mar 30, 2026
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the integration-tests GitHub Actions workflow to reduce brittle expression interpolation in bash and to more accurately fail when the Chainlink image build is cancelled/failed.
Changes:
- Pass
needs.*values into steps viaenv:and reference them as shell variables instead of embedding expressions in bash. - Expand the Chainlink image build gate to fail on
cancelled(and still fail onfailure), while warning onskipped.
Comments suppressed due to low confidence (1)
.github/workflows/integration-tests.yml:630
node_migration_tests_failedis computed usingecho $results | jq ...with an unquoted variable expansion. This allows word-splitting/globbing and can corrupt the JSON (or change it) before it reachesjq, producing incorrect results or parse errors. Quote the variable (or useprintf '%s' "$results") when piping intojq.
results="$TEST_RESULTS"
echo "Core e2e test results:"
echo "$results" | jq .
node_migration_tests_failed=$(echo $results | jq '[.[] | select(.id == "integration-tests/migration/upgrade_version_test.go:*" ) | select(.result != "success")] | length > 0')
gustavogama-cll
approved these changes
Mar 30, 2026
prashantkumar1982
pushed a commit
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes