Skip to content

fix(ci): properly check image build status#21789

Merged
erikburt merged 1 commit intodevelopfrom
fix/integ-test-bypass
Apr 1, 2026
Merged

fix(ci): properly check image build status#21789
erikburt merged 1 commit intodevelopfrom
fix/integ-test-bypass

Conversation

@erikburt
Copy link
Copy Markdown
Collaborator

Changes

  • Switches from templated literals to env vars
  • More robust checks for chainlink image build

@erikburt erikburt self-assigned this Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Mar 30, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_EVM_CallContract_Invalid_Addr_To_Read_Regression/[v2]_EVM.CallContract_-_invalid_address_to_read_fails_with_long_add... The test failed because an unexpected error occurred during EVM contract call, specifically a reentrancy out-of-gas error, and a workflow could not... Logs ↗︎
Test_CRE_V2_EVM_CallContract_Invalid_Addr_To_Read_Regression The test failed without providing specific error details, indicating an unspecified failure in the test case. Logs ↗︎

View Full Report ↗︎Docs

@erikburt erikburt marked this pull request as ready for review March 30, 2026 22:11
@erikburt erikburt requested review from a team as code owners March 30, 2026 22:11
Copilot AI review requested due to automatic review settings March 30, 2026 22:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the integration-tests GitHub Actions workflow to reduce brittle expression interpolation in bash and to more accurately fail when the Chainlink image build is cancelled/failed.

Changes:

  • Pass needs.* values into steps via env: and reference them as shell variables instead of embedding expressions in bash.
  • Expand the Chainlink image build gate to fail on cancelled (and still fail on failure), while warning on skipped.
Comments suppressed due to low confidence (1)

.github/workflows/integration-tests.yml:630

  • node_migration_tests_failed is computed using echo $results | jq ... with an unquoted variable expansion. This allows word-splitting/globbing and can corrupt the JSON (or change it) before it reaches jq, producing incorrect results or parse errors. Quote the variable (or use printf '%s' "$results") when piping into jq.
          results="$TEST_RESULTS"
          echo "Core e2e test results:"
          echo "$results" | jq .

          node_migration_tests_failed=$(echo $results | jq '[.[] | select(.id == "integration-tests/migration/upgrade_version_test.go:*" ) | select(.result != "success")] | length > 0')

@erikburt erikburt added this pull request to the merge queue Apr 1, 2026
Merged via the queue into develop with commit 9805a5c Apr 1, 2026
178 of 180 checks passed
@erikburt erikburt deleted the fix/integ-test-bypass branch April 1, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants