Fix Solana msghasher to handle LOOP gRPC type conversions for SVMExtraArgsV1 by huangzhen1997 · Pull Request #21790 · smartcontractkit/chainlink

huangzhen1997 · 2026-03-31T01:24:38Z

When a non-EVM source chain (e.g. TON) sends a message to Solana, the source chain's ExtraDataCodec runs in a LOOP plugin. The decoded map[string]any goes through gRPC protobuf serialization which
changes Go types:

uint32 → int64
[32]byte → []byte
[][32]byte → []interface{}

The Solana parseExtraDataMap only accepted the native types, causing "invalid type for ComputeUnits/TokenReceiver/Accounts" errors on TON→Solana lanes.

This follows the same pattern as the EVM msghasher which already handles int64 for destGasAmount (see comment on line 303 of deployment/common/msghasher.go).

Adds test coverage for both native and LOOP-converted type paths.

github-actions · 2026-03-31T01:24:57Z

👋 huangzhen1997, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

github-actions · 2026-03-31T01:25:51Z

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

github-actions · 2026-03-31T01:26:18Z

✅ No conflicts with other open PRs targeting develop

Copilot

Pull request overview

Risk Rating: MEDIUM

This PR updates the TON relay dependency and plugin pin, and adjusts Solana CCIP message hashing to correctly parse ExtraArgs maps after LOOP gRPC type conversions (to support TON→Solana flows).

Changes:

Bump github.com/smartcontractkit/chainlink-ton pseudo-version across core, deployment, and test modules.
Update Solana CCIP parseExtraDataMap to accept LOOP-converted types (int64, []byte, []interface{} / [][]byte) and add unit tests.
Update the public plugins manifest to point the TON plugin at the new chainlink-ton gitRef.

Suggested reviewers (per .github/CODEOWNERS):

core/capabilities/ccip/ccipsolana/*: @smartcontractkit/bix-build
/deployment/*: @smartcontractkit/ccip-tooling @smartcontractkit/ccip-offchain @smartcontractkit/operations-platform @smartcontractkit/core
Go module/dependency changes: @smartcontractkit/core @smartcontractkit/foundations (and @smartcontractkit/devex-tooling for /integration-tests/*)

Areas needing scrupulous human review:

parseExtraDataMap type coercions and their impact on CCIP message hash stability across plugin boundaries.
plugins/plugins.public.yaml correctness (invalid YAML will break plugin installation).

Reviewed changes

Copilot reviewed 10 out of 17 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
system-tests/tests/go.mod	Bumps `chainlink-ton` version used by system tests.
system-tests/tests/go.sum	Updates checksums for the new `chainlink-ton` version.
system-tests/lib/go.mod	Bumps `chainlink-ton` version used by system test libraries.
system-tests/lib/go.sum	Updates checksums for the new `chainlink-ton` version.
integration-tests/load/go.mod	Bumps `chainlink-ton` version for load test module.
integration-tests/load/go.sum	Updates checksums for the new `chainlink-ton` version.
integration-tests/go.mod	Bumps `chainlink-ton` version for integration test module.
integration-tests/go.sum	Updates checksums for the new `chainlink-ton` version.
deployment/go.mod	Bumps `chainlink-ton` version for deployment tooling module.
deployment/go.sum	Updates checksums for the new `chainlink-ton` version.
core/scripts/go.mod	Bumps `chainlink-ton` version for scripts module.
core/scripts/go.sum	Updates checksums for the new `chainlink-ton` version.
go.mod	Bumps root module dependency on `chainlink-ton`.
go.sum	Updates root module checksums for the new `chainlink-ton` version.
plugins/plugins.public.yaml	Updates TON plugin gitRef (currently introduces a YAML syntax error).
core/capabilities/ccip/ccipsolana/msghasher.go	Adds LOOP gRPC-aware parsing for Solana ExtraArgs map fields.
core/capabilities/ccip/ccipsolana/msghasher_test.go	Adds unit tests covering native vs LOOP-converted ExtraArgs map types and invalid inputs.

Copilot · 2026-03-31T01:30:00Z

  ton:
    - moduleURI: "github.com/smartcontractkit/chainlink-ton"
-      gitRef: "v0.0.0-20260326230916-bcfdbe85f221"
+      gitRef: "v0.0.0-20260331005855-7b5a4b3384f8


gitRef value is missing a closing quote, which makes this YAML invalid and will likely break loopinstall parsing. Add the terminating " (and keep formatting consistent with other plugin entries).

Suggested change

gitRef: "v0.0.0-20260331005855-7b5a4b3384f8

gitRef: "v0.0.0-20260331005855-7b5a4b3384f8"

Copilot · 2026-03-31T01:30:01Z

 	github.com/smartcontractkit/chainlink-testing-framework/lib v1.54.5
-	github.com/smartcontractkit/chainlink-ton v0.0.0-20260326230916-bcfdbe85f221
+	github.com/smartcontractkit/chainlink-ton v0.0.0-20260331005855-7b5a4b3384f8
 	github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221


chainlink-ton was bumped to a newer pseudo-version, but chainlink-ton/deployment remains pinned to an older commit. Mixing module commits from the same repo can cause subtle incompatibilities and makes it harder to track provenance; consider bumping chainlink-ton/deployment to the matching pseudo-version (or add a comment explaining why it must stay pinned).

Suggested change

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260331005855-7b5a4b3384f8

Copilot · 2026-03-31T01:30:01Z

 	github.com/smartcontractkit/chainlink-testing-framework/seth v1.51.5
-	github.com/smartcontractkit/chainlink-ton v0.0.0-20260326230916-bcfdbe85f221
+	github.com/smartcontractkit/chainlink-ton v0.0.0-20260331005855-7b5a4b3384f8
 	github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221


chainlink-ton was bumped to a newer pseudo-version, but chainlink-ton/deployment remains pinned to an older commit. Mixing module commits from the same repo can cause subtle incompatibilities and makes it harder to track provenance; consider bumping chainlink-ton/deployment to the matching pseudo-version (or add a comment explaining why it must stay pinned).

Suggested change

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260331005855-7b5a4b3384f8

Copilot · 2026-03-31T01:30:01Z

 	github.com/smartcontractkit/chainlink-testing-framework/lib/grafana v1.51.0 // indirect
 	github.com/smartcontractkit/chainlink-testing-framework/parrot v0.6.2 // indirect
 	github.com/smartcontractkit/chainlink-testing-framework/sentinel v0.1.2 // indirect
-	github.com/smartcontractkit/chainlink-ton v0.0.0-20260326230916-bcfdbe85f221 // indirect
+	github.com/smartcontractkit/chainlink-ton v0.0.0-20260331005855-7b5a4b3384f8 // indirect
 	github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221 // indirect
 	github.com/smartcontractkit/chainlink-tron/relayer v0.0.11-0.20260218133534-cbd44da2856b // indirect


chainlink-ton was bumped to a newer pseudo-version, but chainlink-ton/deployment remains pinned to an older commit. Mixing module commits from the same repo can cause subtle incompatibilities and makes it harder to track provenance; consider bumping chainlink-ton/deployment to the matching pseudo-version (or add a comment explaining why it must stay pinned).

Copilot · 2026-03-31T01:30:01Z

 	github.com/smartcontractkit/chainlink-testing-framework/parrot v0.6.2 // indirect
-	github.com/smartcontractkit/chainlink-ton v0.0.0-20260326230916-bcfdbe85f221 // indirect
+	github.com/smartcontractkit/chainlink-ton v0.0.0-20260331005855-7b5a4b3384f8 // indirect
 	github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221 // indirect


chainlink-ton was bumped to a newer pseudo-version, but chainlink-ton/deployment remains pinned to an older commit. Mixing module commits from the same repo can cause subtle incompatibilities and makes it harder to track provenance; consider bumping chainlink-ton/deployment to the matching pseudo-version (or add a comment explaining why it must stay pinned).

Suggested change

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221 // indirect

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260331005855-7b5a4b3384f8 // indirect

Copilot · 2026-03-31T01:30:02Z

 	github.com/smartcontractkit/chainlink-testing-framework/parrot v0.6.2 // indirect
-	github.com/smartcontractkit/chainlink-ton v0.0.0-20260326230916-bcfdbe85f221 // indirect
+	github.com/smartcontractkit/chainlink-ton v0.0.0-20260331005855-7b5a4b3384f8 // indirect
 	github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221 // indirect


chainlink-ton was bumped to a newer pseudo-version, but chainlink-ton/deployment remains pinned to an older commit. Mixing module commits from the same repo can cause subtle incompatibilities and makes it harder to track provenance; consider bumping chainlink-ton/deployment to the matching pseudo-version (or add a comment explaining why it must stay pinned).

Suggested change

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221 // indirect

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260331005855-7b5a4b3384f8 // indirect

Copilot · 2026-03-31T01:30:02Z

 	github.com/smartcontractkit/chainlink-testing-framework/parrot v0.6.2 // indirect
-	github.com/smartcontractkit/chainlink-ton v0.0.0-20260326230916-bcfdbe85f221 // indirect
+	github.com/smartcontractkit/chainlink-ton v0.0.0-20260331005855-7b5a4b3384f8 // indirect
 	github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221 // indirect


chainlink-ton was bumped to a newer pseudo-version, but chainlink-ton/deployment remains pinned to an older commit. Mixing module commits from the same repo can cause subtle incompatibilities and makes it harder to track provenance; consider bumping chainlink-ton/deployment to the matching pseudo-version (or add a comment explaining why it must stay pinned).

Suggested change

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221 // indirect

github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260331005855-7b5a4b3384f8 // indirect

trunk-io · 2026-03-31T01:47:18Z

_{View Full Report ↗︎ ⋅ Docs}

cl-sonarqube-production · 2026-03-31T02:00:18Z

Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

…raArgsV1 (#21790) * bump cl-ton first * fix solana extra data handler * fix yaml * lint

huangzhen1997 added 2 commits March 30, 2026 20:08

bump cl-ton first

8c41ba7

fix solana extra data handler

2399f0f

huangzhen1997 requested review from a team as code owners March 31, 2026 01:24

Copilot AI review requested due to automatic review settings March 31, 2026 01:24

product-security-plaid-production Bot requested review from DylanTinianov, archseer and gustavogama-cll March 31, 2026 01:24

Copilot started reviewing on behalf of huangzhen1997 March 31, 2026 01:25 View session

huangzhen1997 changed the title ~~Jh/support for ton to solana~~ Fix Solana msghasher to handle LOOP gRPC type conversions for SVMExtraArgsV1 Mar 31, 2026

Copilot AI reviewed Mar 31, 2026

View reviewed changes

fix yaml

163685d

archseer enabled auto-merge March 31, 2026 01:33

archseer previously approved these changes Mar 31, 2026

View reviewed changes

ogtownsend previously approved these changes Mar 31, 2026

View reviewed changes

lint

e5b6d9f

huangzhen1997 dismissed stale reviews from ogtownsend and archseer via e5b6d9f March 31, 2026 01:42

HashWrangler approved these changes Mar 31, 2026

View reviewed changes

archseer approved these changes Mar 31, 2026

View reviewed changes

archseer added this pull request to the merge queue Mar 31, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026

archseer added this pull request to the merge queue Mar 31, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026

archseer added this pull request to the merge queue Mar 31, 2026

Merged via the queue into develop with commit 2f75e59 Mar 31, 2026
220 of 222 checks passed

archseer deleted the jh/support-for-ton-to-solana branch March 31, 2026 05:19

krebernisak mentioned this pull request Mar 31, 2026

SUI - fix ExtraData parsing (LOOP) #21796

Merged

prashantkumar1982 pushed a commit that referenced this pull request Apr 2, 2026

Fix Solana msghasher to handle LOOP gRPC type conversions for SVMExt…

fb712af

…raArgsV1 (#21790) * bump cl-ton first * fix solana extra data handler * fix yaml * lint

huangzhen1997 added a commit that referenced this pull request Apr 7, 2026

Fix Solana msghasher to handle LOOP gRPC type conversions for SVMExt…

e286582

…raArgsV1 (#21790) * bump cl-ton first * fix solana extra data handler * fix yaml * lint

huangzhen1997 mentioned this pull request Apr 22, 2026

Update Solana off-chain codec smartcontractkit/chainlink-solana#1539

Open

	gitRef: "v0.0.0-20260331005855-7b5a4b3384f8
	gitRef: "v0.0.0-20260331005855-7b5a4b3384f8"

	github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260326230916-bcfdbe85f221
	github.com/smartcontractkit/chainlink-ton/deployment v0.0.0-20260331005855-7b5a4b3384f8

Conversation

huangzhen1997 commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

github-actions Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

trunk-io Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cl-sonarqube-production Bot commented Mar 31, 2026

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

huangzhen1997 commented Mar 31, 2026 •

edited

Loading

github-actions Bot commented Mar 31, 2026 •

edited

Loading

trunk-io Bot commented Mar 31, 2026 •

edited

Loading