[DX-3609] migrate GRPC source tests to ChIP test sink#21795
Merged
Conversation
Tofel
changed the title
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM (shared system-test helper + behavior changes in a lifecycle smoke test)
This PR migrates the gRPC source system tests from using a Beholder subscription to using the CHiP test sink, and updates lifecycle assertions to match workflow lifecycle v2 events coming from CHiP.
Changes:
- Add a generic
proto.Messagesafe-send helper and a CHiP publish handler that demuxes workflow lifecycle v2 events. - Update
v2_grpc_source_testto start a CHiP test sink instead of Beholder and to assert lifecycle events by workflow ID. - Simplify “isolation baseline” checks by verifying node health instead of relying on a contract workflow activation event.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
system-tests/tests/test-helpers/chip_testsink_helpers.go |
Adds safeSendProtoMessage and GetWorkflowV2LifecyclePublishFn to support routing workflow v2 lifecycle events from CHiP into tests. |
system-tests/tests/smoke/cre/v2_grpc_source_test.go |
Replaces Beholder event listening with CHiP sink, updates lifecycle assertions to filter by workflow ID, and adjusts helper logic accordingly. |
Scrupulous human review focus areas:
assertWorkflowEvent/assertNoWorkflowActivatedchannel-read loops (closed-channel behavior can create tight loops).GetWorkflowV2LifecyclePublishFnunmarshalling + event type routing (ensuring CHiP event payloads and types align with what the test expects).- Workflow ID normalization/matching logic (ensuring CHiP emits the same ID format as
hex.EncodeToString([32]byte)).
Reviewer recommendations (from .github/CODEOWNERS):
@smartcontractkit/foundations,@smartcontractkit/core(default owners apply to these paths)
Tofel
force-pushed
the
dx-3609-grpc-source-tests-test-sink
branch
from
18e0c48 to
e4c451e
Compare
|
mchain0
approved these changes
Mar 31, 2026
vyzaldysanchez
approved these changes
Apr 1, 2026
prashantkumar1982
pushed a commit
that referenced
this pull request
Apr 2, 2026
migrate GRPC source tests to ChIP test sink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.