Skip to content

Populate WorkflowOwner field in gateway handler requests#21859

Merged
george-dorin merged 2 commits intodevelopfrom
fix-vault-owner-missmatch
Apr 3, 2026
Merged

Populate WorkflowOwner field in gateway handler requests#21859
george-dorin merged 2 commits intodevelopfrom
fix-vault-owner-missmatch

Conversation

@george-dorin
Copy link
Copy Markdown
Contributor

@george-dorin george-dorin commented Apr 3, 2026

  • Set WorkflowOwner field on vault requests
  • Always set WorkflowOwner on GetSecretsRequest for label validation
  • Update tests to reflect the new behavior

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

👋 george-dorin, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

✅ No conflicts with other open PRs targeting develop

mchain0
mchain0 previously approved these changes Apr 3, 2026
@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 3, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_EVM_WriteReport_Invalid_Gas_Regression/[v2]_EVM.WriteReport_-_invalid_gas_fails_with_too_high The test failed because it did not find the expected user log message indicating invalid gas input. Logs ↗︎

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
28.6% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@george-dorin george-dorin enabled auto-merge April 3, 2026 14:24
@george-dorin george-dorin added this pull request to the merge queue Apr 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2026
@george-dorin george-dorin added this pull request to the merge queue Apr 3, 2026
Merged via the queue into develop with commit eb25fa1 Apr 3, 2026
251 of 258 checks passed
@george-dorin george-dorin deleted the fix-vault-owner-missmatch branch April 3, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants