[DX-3583] Modify legacy nightly system tests triggers#21876
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Tofel
force-pushed
the
dx-3583-nightly-public-images
branch
2 times, most recently
from
7fe73fe to
77f5853
Compare
product-security-plaid-production
bot
requested review from
chainchad,
george-dorin and
skudasov
mchain0
previously approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — changes affect nightly CI orchestration and image selection for legacy system tests.
Updates legacy nightly system test triggering so runs can be driven via workflow inputs and can also be invoked after the nightly Docker image build completes.
Changes:
- Converted
legacy-system-tests-nightly.ymlto be driven viaworkflow_dispatch/workflow_callinputs for Chainlink image selection (full image vs repo+tag) and checkout ref. - Added Chainlink image resolution + ECR (private/public) login steps to the legacy system tests workflow.
- Updated
docker-build.ymlto call the legacy nightly system tests workflow onschedule/workflow_dispatchafterdocker-corefinishes, passing the built image tag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/legacy-system-tests-nightly.yml |
Adds inputs and resolves Chainlink image/tag at runtime; updates AWS auth + ECR login to support private/public registries. |
.github/workflows/docker-build.yml |
Invokes legacy system tests after nightly core image build on scheduled/dispatch runs; aligns chainlink_version passed to downstream workflows with the checked-out ref/SHA. |
Scrupulous human review recommended (high-impact blocks):
.github/workflows/legacy-system-tests-nightly.yml: theResolve Chainlink imageenv wiring in bothsummaryandtest-nightlyjobs (mutual exclusivity handling and correctness of the selected image reference)..github/workflows/docker-build.yml: the newcall-legacy-system-testsjob wiring (trigger conditions + ensuring the intended image/tag is passed through fromdocker-coreoutputs).
Tofel
force-pushed
the
dx-3583-nightly-public-images
branch
from
c33ba84 to
9b84360
Compare
skudasov
previously approved these changes
Apr 9, 2026
Tofel
force-pushed
the
dx-3583-nightly-public-images
branch
2 times, most recently
from
ac5752f to
735c986
Compare
skudasov
previously approved these changes
Apr 13, 2026
mchain0
previously approved these changes
Apr 13, 2026
chainchad
reviewed
Apr 13, 2026
…er it from docker-build instead of schedule
Tofel
force-pushed
the
dx-3583-nightly-public-images
branch
from
735c986 to
e65019f
Compare
mchain0
approved these changes
Apr 13, 2026
chainchad
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run legacy nightly system tests with:
docker-build)Tests: