Skip to content

add solana signature exclusion test for hasher #21891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Unheilbar wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

add solana signature exclusion test for hasher #21891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c566ce
add solana signature exclusion test for hasher
Unheilbar Apr 7, 2026
cc48557
fix test
Unheilbar Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions core/capabilities/remote/executable/hasher_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ func TestWriteReportExcludeSignaturesHasher_Hash(t *testing.T) {
req1a := getRequest(t, []byte("testdata"), [][]byte{[]byte("sig1"), []byte("sig2")})
req1b := getRequest(t, []byte("testdata"), [][]byte{[]byte("sig3"), []byte("sig4")})
req2 := getRequest(t, []byte("otherdata"), [][]byte{[]byte("sig1"), []byte("sig2")})
reqSola := getSolWriteRequest(t, []byte("testdata"), [][]byte{[]byte("sig1"), []byte("sig2")})
reqSolb := getSolWriteRequest(t, []byte("testdata"), [][]byte{[]byte("sig3"), []byte("sig4")})
reqSol2 := getSolWriteRequest(t, []byte("otherdata"), [][]byte{[]byte("sig1"), []byte("sig2")})

hasher := NewWriteReportExcludeSignaturesHasher()
hash1a, err := hasher.Hash(req1a)
Expand All @@ -27,6 +30,15 @@ func TestWriteReportExcludeSignaturesHasher_Hash(t *testing.T) {
require.NoError(t, err)
hash2, err := hasher.Hash(req2)
require.NoError(t, err)
hash1sola, err := hasher.Hash(reqSola)
require.NoError(t, err)
hash1solb, err := hasher.Hash(reqSolb)
require.NoError(t, err)
hashsol2, err := hasher.Hash(reqSol2)
require.NoError(t, err)

require.Equal(t, hash1sola, hash1solb)
require.NotEqual(t, hash1sola, hashsol2)

require.Equal(t, hash1a, hash1b) // same data, different signatures
require.NotEqual(t, hash1a, hash2) // different data, same signatures
Expand Down Expand Up @@ -186,6 +198,33 @@ func getRequest(t *testing.T, data []byte, sigs [][]byte) *types.MessageBody {
CapabilityId: "evm:123",
}
}
func getSolWriteRequest(t *testing.T, data []byte, sigs [][]byte) *types.MessageBody {
attrSigs := []*sdk.AttributedSignature{}
for i, sig := range sigs {
attrSigs = append(attrSigs, &sdk.AttributedSignature{
Signature: sig,
SignerId: uint32(i), //nolint:gosec // G115
})
}
report := &sdk.ReportResponse{
RawReport: data,
Sigs: attrSigs,
}
wrReq := &solcappb.WriteReportRequest{
Report: report,
}
wrAny, err := anypb.New(wrReq)
require.NoError(t, err)
capReq := capabilities.CapabilityRequest{
Payload: wrAny,
}
capReqBytes, err := pb.MarshalCapabilityRequest(capReq)
require.NoError(t, err)
return &types.MessageBody{
Payload: capReqBytes,
CapabilityId: "solana:abc",
}
}

func getRequestWithMetadata(t *testing.T, data []byte, md capabilities.RequestMetadata) *types.MessageBody {
report := &sdk.ReportResponse{
Expand Down
Loading