Skip to content

chore: remove unused timelock converter helper [CLD-1910]#21950

Merged
gustavogama-cll merged 5 commits intodevelopfrom
ecpablo/remove-converter-helper
Apr 11, 2026
Merged

chore: remove unused timelock converter helper [CLD-1910]#21950
gustavogama-cll merged 5 commits intodevelopfrom
ecpablo/remove-converter-helper

Conversation

@ecPablo
Copy link
Copy Markdown
Contributor

@ecPablo ecPablo commented Apr 9, 2026

The McmsTimelockConverterForChain was unused in the repo and on our other usages.

AI Summary

This pull request removes the McmsTimelockConverterForChain function from mcms_helpers.go. This function was responsible for returning the appropriate TimelockConverter implementation based on the chain family. No other significant changes are included.

  • Removed the McmsTimelockConverterForChain function, which selected and returned a TimelockConverter implementation depending on the chain family (EVM, Solana, etc.), from mcms_helpers.go.

@ecPablo ecPablo requested a review from Copilot April 9, 2026 20:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

✅ No conflicts with other open PRs targeting develop

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused exported helper (McmsTimelockConverterForChain) from the MCMS proposal utilities, reducing dead code.

Changes:

  • Deleted McmsTimelockConverterForChain from mcms_helpers.go.

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 9, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@ecPablo ecPablo marked this pull request as ready for review April 10, 2026 15:56
@ecPablo ecPablo requested a review from a team as a code owner April 10, 2026 15:56
@cl-sonarqube-production
Copy link
Copy Markdown

@ecPablo ecPablo requested a review from a team April 10, 2026 20:18
@gustavogama-cll gustavogama-cll added this pull request to the merge queue Apr 11, 2026
Merged via the queue into develop with commit 8408484 Apr 11, 2026
487 of 499 checks passed
@gustavogama-cll gustavogama-cll deleted the ecpablo/remove-converter-helper branch April 11, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants