fix(ci): pass unique artifact-name per matrix job to prevent 409 collision#21977
fix(ci): pass unique artifact-name per matrix job to prevent 409 collision#21977
Conversation
…ision
Multiple matrix jobs with trunk-auto-quarantine enabled (go_core_tests,
go_core_tests_integration, go_core_ccip_deployment_tests) all upload an
artifact named 'individual_test_logs' in the same workflow run, causing a
deterministic 409 conflict that fails CI even when tests pass.
Pass artifact-name: ${{ matrix.type.cmd }}_test_logs so each job gets a
unique artifact name. Depends on smartcontractkit/.github#1512.
Fixes: CORE-2418
product-security-plaid-production
bot
requested review from
ChrisAmora and
kalverra
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
Prevents 409 conflict when multiple matrix jobs fail simultaneously and attempt to upload artifacts with the same hardcoded name. Fixes: smartcontractkit/.github/actions/branch-out-upload (artifact-name input)
⛔ Do Not Merge Yet — Waiting on DependencyThis PR depends on smartcontractkit/.github#1512 which adds the Merge order:
Until step 2 is complete, the |
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 participants
Summary
artifact-name: ${{ matrix.type.cmd }}_test_logstobranch-out-uploadso each matrix job uploads a uniquely named artifactProblem
go_core_tests,go_core_tests_integration, andgo_core_ccip_deployment_testsall havetrunk-auto-quarantine: trueand callbranch-out-uploadin the same workflow run. The action hardcodes the artifact nameindividual_test_logs, causing a deterministic 409 conflict — the second job to upload always fails, even when tests pass. This affects every PR touching core Go code.Dependency
Requires smartcontractkit/.github#1512 to be merged and the
branch-out-upload/v1tag updated first. Until then, theartifact-nameinput is silently ignored (composite actions don't fail on unknown inputs), so this PR is safe to merge in any order.Test plan
v1tag is updated, bothgo_core_testsandgo_core_tests_integrationshould upload separate artifacts (go_core_tests_test_logsandgo_core_tests_integration_test_logs) with no 409 conflictFixes: CORE-2418