Skip to content

fix(test): Restore const#21990

Merged
pavel-raykov merged 1 commit intodevelopfrom
restore-const
Apr 13, 2026
Merged

fix(test): Restore const#21990
pavel-raykov merged 1 commit intodevelopfrom
restore-const

Conversation

@pavel-raykov
Copy link
Copy Markdown
Collaborator

follow-up to #21957

@pavel-raykov pavel-raykov marked this pull request as ready for review April 13, 2026 11:38
@pavel-raykov pavel-raykov requested review from a team as code owners April 13, 2026 11:38
@pavel-raykov pavel-raykov requested review from Copilot and jmank88 April 13, 2026 11:38
@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@pavel-raykov pavel-raykov requested a review from Fletch153 April 13, 2026 11:38
@pavel-raykov pavel-raykov enabled auto-merge April 13, 2026 11:38
@github-actions
Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a follow-up to #21957 and restores defaultExpiration in the OCR2 promwrapper plugin back to a const, while keeping defaultCleanupInterval as a var so tests can still disable go-cache GC when using synctest.

Changes:

  • Convert defaultExpiration from a var back to a const.
  • Keep defaultCleanupInterval as an overridable var (used by tests to disable cache GC).

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 13, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_Aptos_Suite/[v2]_Aptos The test failed during the Aptos suite, but the specific cause of failure is not provided in the log. Logs ↗︎
Test_CRE_V2_Aptos_Suite/[v2]_Aptos/Aptos_Write_Read_Roundtrip The test failed because it did not find the expected user log message during the Aptos write-read roundtrip test. Logs ↗︎
Test_CRE_V2_Aptos_Suite The test failed without a specific error message, indicating an unspecified failure during execution. Logs ↗︎

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

@pavel-raykov pavel-raykov added this pull request to the merge queue Apr 13, 2026
Merged via the queue into develop with commit 2e070ce Apr 13, 2026
257 of 262 checks passed
@pavel-raykov pavel-raykov deleted the restore-const branch April 13, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants