remove mentions to --with-plugins-docker-image#22059
Conversation
|
I see you updated files related to
|
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Removes user-facing references to the deprecated --with-plugins-docker-image flag from Local CRE setup messaging and (intended) shell completions.
Changes:
- Removed the
--with-plugins-docker-imagehint from the post-setup “how to start” instructions. - Removed
--with-plugins-docker-imagefrom the legacy/manual completion tree list incompletions.go.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/scripts/cre/environment/environment/setup.go | Drops the deprecated flag from printed “Optional” startup guidance. |
| core/scripts/cre/environment/completions.go | Removes the deprecated flag from the legacy/manual completion list (note: current completions are built from Cobra). |
| {Text: "--wait-on-error-timeout", Description: "Time to wait before removing Docker containers if environment fails to start (e.g. 10s, 1m, 1h) (default: 15s)"}, | ||
| {Text: "--extra-allowed-gateway-ports", Description: "Extra allowed ports for outgoing connections from the Gateway Connector (e.g. 8080,8081)"}, | ||
| {Text: "--with-example", Description: "Deploys and registers example workflow (default: false)"}, | ||
| {Text: "--example-workflow-timeout", Description: "Time to wait until example workflow succeeds (e.g. 10s, 1m, 1h) (default: 5m)"}, | ||
| {Text: "--with-plugins-docker-image", Description: "Docker image to use (must have all capabilities included)"}, | ||
| {Text: "--with-beholder", Description: "Deploys Beholder (Chip Ingress + Red Panda) (default: false)"}, |
There was a problem hiding this comment.
This removal is in buildCommandTree(), but StartShell() initializes completions via buildCommandTreeFromCobra() (which introspects Cobra flags). Since the --with-plugins-docker-image flag is still defined on the Cobra command tree, it will still be suggested in the interactive shell despite this change. If the intent is to remove completion mentions, either filter it out in extractFlagsFromCobraCommand (e.g., skip deprecated/hidden flags) and/or mark the flag hidden in the Cobra command definition.
|
No description provided.