[CRE-3579] fix: flaky Test_StratReconciliation_RetriesWithBackoff#22082
Merged
Conversation
Fix data race on retryCount (plain int accessed across goroutines without synchronization) by using atomic.Int32. Also fix the test to actually verify retry behavior: wait for the full retry cycle (2 failures + 1 success) instead of exiting after the first failed attempt. Use a faster ticker and shorter retry interval to avoid unnecessary slowness. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
👋 aareet, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
aareet
changed the title
Contributor
|
✅ No conflicts with other open PRs targeting |
|
justinkaseman
approved these changes
Apr 20, 2026
jmank88
approved these changes
Apr 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRE-3579 - Fix flaky Test_StratReconciliation_RetriesWithBackoff
retryCountvariable (plainintaccessed across goroutines without synchronization) by usingatomic.Int321s) and shorter retry interval (100ms) to reduce test duration and timing sensitivityTest plan
-race -count=5Test_StratReconciliation_RetriesWithBackoffno longer flakes🤖 Generated with Claude Code