ignore SLOW SQL QUERY critical log in all log poller tests

[Tofel]

• fix bug in load test log scanners

[github-actions]

✅ No conflicts with other open PRs targeting develop

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[Copilot]

Pull request overview

Risk Rating: LOW (test-only changes, but affects failure diagnostics and log-scan gating)

This PR updates devenv test log-scanning behavior to ignore expected “SLOW SQL QUERY” critical/DPanic logs in log poller tests and adjusts cleanup log scanning in some soak/load tests.

Changes:

• Centralizes an allowed log message (ignoredSlowQueryLog) and passes it into all log poller test runners.
• Updates executeLogPollerReplay to accept allowed log messages (but currently doesn’t apply them in cleanup scanning).
• Removes immediate t.Error reporting of log-scan errors in OCR2 soak and automation load test cleanups.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
devenv/tests/ocr2/soak_test.go	Removes early t.Error for log scan failures during cleanup.
devenv/tests/logpoller/logpoller_test.go	Adds shared ignored “SLOW SQL QUERY” allowed message and threads it through log poller test helpers.
devenv/tests/automation/load_test.go	Removes early t.Error for log scan failures during cleanup.

Comments suppressed due to low confidence (2)

devenv/tests/automation/load_test.go:87

• With the t.Error removal, scanErr won’t cause t.Failed() to be true until the final require.NoError, so the log-saving branch is skipped when log scanning fails. Save container logs when scanErr != nil (e.g., if t.Failed() || scanErr != nil) so failures in the log scanner still capture logs for debugging.

		if t.Failed() {
			saveErr := framework.StreamCTFContainerLogsFanout(
				framework.LogStreamConsumer{
					Name: "save-container-logs",
					Consume: func(logStreams map[string]io.ReadCloser) error {
						_, saveErr := framework.SaveContainerLogsFromStreams(fmt.Sprintf("%s-%d", framework.DefaultCTFLogsDir, time.Now().UnixNano()), logStreams)
						return saveErr

devenv/tests/ocr2/soak_test.go:52

• Removing the early t.Error means a non-nil scanErr no longer marks the test as failed until the final require.NoError, so the if t.Failed() branch won’t run and container logs won’t be saved for log-scan failures. Consider saving logs when scanErr != nil as well (e.g., if t.Failed() || scanErr != nil), and update the final error message to reflect a scan failure rather than a save failure.

		if t.Failed() {
			saveErr := framework.StreamCTFContainerLogsFanout(
				framework.LogStreamConsumer{
					Name: "save-container-logs",
					Consume: func(logStreams map[string]io.ReadCloser) error {

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube