fix: add manual check with retry logic to BundleAggregatorProxy deployments tx receipt#22136
Merged
karen-stepanyan merged 7 commits intodevelopfrom Apr 22, 2026
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR hardens data-feeds contract deployment verification by replacing bind.WaitDeployed / single CodeAt checks with a bounded retry loop that waits for contract code to appear after the deployment tx is confirmed (notably for BundleAggregatorProxy).
Changes:
- Introduces
waitForContractCodeusing a capped Fibonacci backoff with a 90s max duration. - Uses the new helper to verify deployments for
DataFeedsCache,AggregatorProxy, andBundleAggregatorProxy. - Adjusts
BundleAggregatorProxy“code verified” logging fields.
Comments suppressed due to low confidence (1)
deployment/data-feeds/changeset/deploy.go:168
- The debug log for the successful BundleAggregatorProxy deployment verification no longer includes the
txHash(and previously includedcodeSize). KeepingtxHashin this log line is useful for tracing deployments in RPC/indexer issues, and it’s still available astx.Hash()even if you no longer log code size.
proxyContract, err := bundleproxy.NewBundleAggregatorProxy(proxyAddr, chain.Client)
if err != nil {
return nil, fmt.Errorf("failed to bind BundleAggregatorProxy at %s: %w", proxyAddr, err)
|
|
anirudhwarrier
approved these changes
Apr 22, 2026
gustavogama-cll
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Requires
Supports