[CRE-4087] Add support for Vault OCR3 and DKG Plugins to the capabilities registry#22270
Merged
cedric-cordenier merged 1 commit intodevelopfrom May 5, 2026
Merged
[CRE-4087] Add support for Vault OCR3 and DKG Plugins to the capabilities registry#22270cedric-cordenier merged 1 commit intodevelopfrom
cedric-cordenier merged 1 commit intodevelopfrom
Conversation
product-security-plaid-production
Bot
requested review from
fernandofederico1984 and
gustavogama-cll
Contributor
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — introduces new OCR3.1/DKG config generation paths and a version switch in capabilities-registry config expansion.
This PR extends CRE deployment tooling to support OCR3.1 (including DKG and Vault plugin offchain configs) and allows capabilities-registry OCR config expansion to select the OCR version per entry.
Changes:
- Add OCR3.1 registry helpers (
ComputeOCR3_1Config,ComputeDKGConfig) and support deriving OCR3.1 offchain config bytes from structured config (DKG/Vault) when no override is provided. - Refactor DKG OCR3.1 config generation to reuse the shared OCR3.1 config builder and centralize identity derivation.
- Update capabilities-registry OCR config expansion to support
__ocrVersion__selection (ocr3,ocr3_1,ocr3_1_DKG) and adjust test expectation text.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/cre/ocr3/ocr3_1/registry.go | New entrypoints to compute OCR3.1 and DKG configs using JD-fetched node info. |
| deployment/cre/ocr3/ocr3_1/oracle_config.go | New structured offchain config types (DKG/Vault) with marshaling support. |
| deployment/cre/ocr3/ocr3_1/config_dkg.go | Refactors DKG config generation to reuse shared OCR3.1 builder and adds identity derivation helper. |
| deployment/cre/ocr3/ocr3_1/config.go | Adds fallback logic to marshal offchain config from V3_1OracleConfig when no override is provided. |
| deployment/cre/capabilities_registry/v2/changeset/configure_capabilities_registry.go | Adds OCR version switching and parsing for OCR3.1/DKG configs during expansion. |
| deployment/cre/capabilities_registry/v2/changeset/expand_ocr3_configs_test.go | Updates an assertion string to match new error wording. |
Comment on lines
+39
to
+44
|
|
||
| pkBytesFixed := [ed25519.PublicKeySize]byte{} | ||
| nCopied := copy(pkBytesFixed[:], pkBytes) | ||
| if nCopied != ed25519.PublicKeySize { | ||
| return nil, nil, fmt.Errorf("wrong num elements copied from ocr2 offchain public key. expected %d but got %d", ed25519.PublicKeySize, nCopied) | ||
| } |
cedric-cordenier
force-pushed
the
vault-ocr3-changes
branch
5 times, most recently
from
ba5c3c6 to
9cc7317
Compare
cedric-cordenier
changed the title
cedric-cordenier
force-pushed
the
vault-ocr3-changes
branch
from
9cc7317 to
d6b64f9
Compare
- Including support for Vault and DKG
cedric-cordenier
force-pushed
the
vault-ocr3-changes
branch
from
d6b64f9 to
56410f0
Compare
|
george-dorin
approved these changes
May 5, 2026
justinkaseman
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports