Clean up error messages and checks in CCIP Solana msghasher.go

[vicentevieytes]

Requires

Supports

[github-actions]

👋 vicentevieytes, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[Copilot]

Pull request overview

Risk Rating: MEDIUM — changes affect Solana CCIP message hashing inputs; incorrect parsing can cause hash mismatches or unexpected failures when running via LOOP/gRPC.

This PR addresses a security/robustness gap in parseExtraDataMap by preventing negative int64 values (coming from LOOP/gRPC type coercion) from being silently cast into uint64 for AccountIsWritableBitmap, and updates several type-mismatch errors to reflect the additional accepted LOOP representations.

Changes:

• Add a lower-bound check (v < 0) before casting int64 to uint64 for AccountIsWritableBitmap.
• Improve error messages to reflect accepted types for ComputeUnits, AccountIsWritableBitmap, Accounts, and TokenReceiver.

Scrupulous human review recommended (targeted areas):

• parseExtraDataMap numeric casting behavior for AccountIsWritableBitmap (int64 → uint64) when running through LOOP/gRPC, to confirm this matches the intended “valid range” semantics for the bitmap and won’t break any legitimate payloads.

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)
8.33% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE