Skip to content

bump common for loop fixes#22293

Merged
jmank88 merged 1 commit intodevelopfrom
bump-common-5-4-26
May 4, 2026
Merged

bump common for loop fixes#22293
jmank88 merged 1 commit intodevelopfrom
bump-common-5-4-26

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented May 4, 2026

@jmank88 jmank88 requested review from a team as code owners May 4, 2026 19:21
@jmank88 jmank88 requested review from krebernisak and ogtownsend and removed request for ChrisAmora May 4, 2026 19:22
@jmank88 jmank88 requested a review from pavel-raykov May 4, 2026 19:22
@jmank88 jmank88 enabled auto-merge May 4, 2026 19:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

👋 jmank88, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 4, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestBuildProposalFromBatchesV2 The test failed during a build process, but the specific cause of failure is not indicated in the provided logs. Logs ↗︎

View Full Report ↗︎Docs

@jmank88 jmank88 added this pull request to the merge queue May 4, 2026
@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 4, 2026
@jmank88 jmank88 added this pull request to the merge queue May 4, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 4, 2026
@jmank88 jmank88 added this pull request to the merge queue May 4, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 4, 2026
@jmank88 jmank88 added this pull request to the merge queue May 4, 2026
Merged via the queue into develop with commit 2d2d90a May 4, 2026
231 of 232 checks passed
@jmank88 jmank88 deleted the bump-common-5-4-26 branch May 4, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants