Skip to content

chore(ci): remove old dependency check workflow#22346

Merged
erikburt merged 1 commit intodevelopfrom
chore/rm-dependency-check-workflow
May 7, 2026
Merged

chore(ci): remove old dependency check workflow#22346
erikburt merged 1 commit intodevelopfrom
chore/rm-dependency-check-workflow

Conversation

@erikburt
Copy link
Copy Markdown
Collaborator

@erikburt erikburt commented May 7, 2026

This removes an old workflow that was always skipping. Related to #22070.

This workflow (https://github.com/smartcontractkit/chainlink/blob/develop/.github/workflows/dependency-check.yml) that is not doing anything and is superseded by the org-wide workflow.

  1. The org-wide workflow is "Dependency Review - Vulnerability", and so this one shouldn't be needed
  2. This workflow is currently doing nothing every time.

https://github.com/smartcontractkit/chainlink/actions/workflows/dependency-check.yml?query=is%3Afailure
All failures are actually unrelated to a dependency issue, and due to git/gh availability issues or other things. The only thing this workflow is doing is using github runners, and causing pr + merge queue failures when a git operation fails.

Note

I have already got the previously required check removed.

@erikburt erikburt self-assigned this May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

✅ No conflicts with other open PRs targeting develop

@erikburt erikburt marked this pull request as ready for review May 7, 2026 21:05
@erikburt erikburt requested a review from a team as a code owner May 7, 2026 21:05
Copilot AI review requested due to automatic review settings May 7, 2026 21:05
@erikburt erikburt requested review from a team as code owners May 7, 2026 21:05
@erikburt erikburt enabled auto-merge May 7, 2026 21:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: LOW

Removes a repository-local GitHub Actions workflow (dependency-check.yml) that was effectively non-functional (skipping due to incorrect outputs/conditions) and is superseded by an org-wide dependency review workflow. This should reduce spurious CI/merge-queue failures caused by unrelated runner/git issues in that workflow.

Changes:

  • Deletes the deprecated .github/workflows/dependency-check.yml workflow.
  • Eliminates a broken job-output/conditional chain that prevented the workflow’s vulnerability check steps from ever running.

Areas needing scrupulous human review:

  • Confirm branch protection / merge queue required checks are updated to no longer require the deleted workflow’s check name(s), otherwise PRs could become blocked after merge.

@erikburt erikburt added this pull request to the merge queue May 7, 2026
Merged via the queue into develop with commit e28c9ba May 7, 2026
70 checks passed
@erikburt erikburt deleted the chore/rm-dependency-check-workflow branch May 7, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants