fix: remove and swap usage of run changeset to cld-changeset repo#22432
Conversation
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
✅ No conflicts with other open PRs targeting |
a39a56a to
dcaad84
Compare
dcaad84 to
ca03b7f
Compare
ca03b7f to
63755ee
Compare
|
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH
Migrates remaining RunChangeset call sites from the local deployment helper to the cld-changesets module, while updating related MCMS timelock config usage in CCIP add-chain flows.
Changes:
- Replaced local
RunChangesetimports/calls withcld-changesets/pkg/common/changeset. - Removed the local
deployment/common/changeset/run_changeset.gohelper. - Updated system-test module dependencies and CCIP tests to use V2 MCMS timelock config helpers.
Scrupulous human review areas:
- Removal of exported
RunChangeset/WrappedChangeSetAPI fromdeployment/common/changeset. - CCIP
AddCandidatesForNewChainConfigtype change and conversion into framework MCMS config. - Changeset execution behavior parity between the old local helper and the external
cld-changesetshelper.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
deployment/common/changeset/run_changeset.go |
Removes local exported changeset runner helper. |
deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e.go |
Uses external changeset runner and V2 MCMS config type. |
deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e_test.go |
Updates tests to use V2 timelock config helper. |
deployment/data-feeds/changeset/new_feed_with_proxy.go |
Uses external changeset runner while retaining local ownable contract loader. |
integration-tests/smoke/ccip/ccip_add_chain_e2e_test.go |
Updates integration setup to use V2 timelock config helper. |
system-tests/lib/cre/contracts/contracts.go |
Uses external changeset runner for data feeds cache operations. |
system-tests/lib/go.mod |
Promotes cld-changesets to a direct dependency. |
system-tests/tests/go.mod |
Promotes cld-changesets to a direct dependency. |
system-tests/tests/smoke/cre/por_helpers.go |
Uses external changeset runner for Tron PoR setup. |
system-tests/tests/smoke/cre/sharding_test.go |
Uses external changeset runner for shard count updates. |
Comments suppressed due to low confidence (1)
deployment/common/changeset/run_changeset.go:1
- Removing these exported symbols from the deployment module is a breaking API change for any downstream code that still imports
deployment/common/changeset.RunChangesetorWrappedChangeSet; the internal callers were migrated, but external callers will now fail to compile. Consider keeping a deprecated forwarding wrapper tocld-changesets/pkg/common/changeset.RunChangesetfor a transition period.




Swap usage of run changeset to import cld-changeset.
Updated, merged usage in cld -> https://github.com/smartcontractkit/chainlink-deployments/pull/14076
https://smartcontract-it.atlassian.net/browse/CLD-2108