Skip to content

[CRE-491] Use moved mercury config.#22594

Merged
pavel-raykov merged 3 commits into
developfrom
move-config2
May 22, 2026
Merged

[CRE-491] Use moved mercury config.#22594
pavel-raykov merged 3 commits into
developfrom
move-config2

Conversation

@pavel-raykov
Copy link
Copy Markdown
Collaborator

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 21, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

@pavel-raykov pavel-raykov marked this pull request as ready for review May 22, 2026 10:01
@pavel-raykov pavel-raykov requested a review from a team as a code owner May 22, 2026 10:01
Copilot AI review requested due to automatic review settings May 22, 2026 10:01
@pavel-raykov pavel-raykov requested review from a team as code owners May 22, 2026 10:01
@pavel-raykov pavel-raykov requested a review from jmank88 May 22, 2026 10:01
@pavel-raykov pavel-raykov enabled auto-merge May 22, 2026 10:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: HIGH — This PR changes a core configuration interface (Mercury) and threads the new type through multiple services/modules, coupled with a dependency bump that must align with an external upstream PR.

Changes:

  • Bump github.com/smartcontractkit/chainlink-data-streams to v0.1.15-0.20260522094612-5f9f748bd87a across root/deployment/scripts/system/integration test modules and plugin manifest.
  • Migrate Mercury config interface usage from core/config to chainlink-data-streams/llo/transmitter/de.
  • Remove core/config/mercury_config.go (old Mercury config interface definitions) and update consumers/mocks accordingly.

Areas requiring scrupulous human review:

  • All wiring points that pass cfg.Mercury() into relayers/registries/delegates (ensure the new de.Mercury interface exactly matches expectations of downstream users and that no runtime assumptions changed).
  • core/services/relay/evm Mercury transmitter configuration flow (interface boundary changes + dependency bump can silently alter behavior).
  • Ensure the required upstream PR (chainlink-data-streams#241) is merged and that the referenced pseudo-version contains the moved config API.

Reviewed changes

Copilot reviewed 18 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
system-tests/tests/go.sum Updates chainlink-data-streams checksum for system test module.
system-tests/tests/go.mod Bumps indirect chainlink-data-streams dependency for system test module.
system-tests/lib/go.sum Updates chainlink-data-streams checksum for system test lib module.
system-tests/lib/go.mod Bumps indirect chainlink-data-streams dependency for system test lib module.
plugins/plugins.public.yaml Updates streams plugin gitRef to the new chainlink-data-streams version.
plugins/loop_registry.go Switches registry Mercury config type from core/config to de.Mercury.
plugins/loop_registry_test.go Updates Mercury config mocks to use llo/transmitter/de interfaces.
plugins/cmd/chainlink-evm/main.go Updates Mercury transmitter config interface usage to llo/transmitter/de.
integration-tests/load/go.sum Updates chainlink-data-streams checksum for load tests module.
integration-tests/load/go.mod Bumps indirect chainlink-data-streams dependency for load tests module.
integration-tests/go.sum Updates chainlink-data-streams checksum for integration tests module.
integration-tests/go.mod Bumps indirect chainlink-data-streams dependency for integration tests module.
go.sum Updates root module chainlink-data-streams checksum.
go.mod Bumps root module chainlink-data-streams dependency.
deployment/go.sum Updates chainlink-data-streams checksum for deployment module.
deployment/go.mod Bumps chainlink-data-streams dependency for deployment module.
core/services/relay/evm/evm.go Points Mercury transmitter config types to llo/transmitter/de.
core/services/ocr2/delegate.go Updates delegate config Mercury type and related interfaces to de.*.
core/services/chainlink/relayer_factory.go Updates factory config to accept de.Mercury via llo/transmitter/de.
core/services/chainlink/mocks/general_config.go Updates generated mock method signatures/returns for Mercury to de.Mercury.
core/services/chainlink/config_mercury.go Updates Mercury config adapters to implement llo/transmitter/de interfaces.
core/services/chainlink/config_general.go Updates Mercury() to return de.Mercury.
core/scripts/go.sum Updates chainlink-data-streams checksum for scripts module.
core/scripts/go.mod Bumps chainlink-data-streams dependency for scripts module.
core/config/mercury_config.go Removes old Mercury config interfaces from core/config.
core/config/app_config.go Updates AppConfig.Mercury() to return de.Mercury.
Files not reviewed (1)
  • core/services/chainlink/mocks/general_config.go: Language not supported

Comment thread core/services/relay/evm/evm.go
@pavel-raykov pavel-raykov added this pull request to the merge queue May 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 22, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue May 22, 2026
Merged via the queue into develop with commit 94f0576 May 22, 2026
224 checks passed
@pavel-raykov pavel-raykov deleted the move-config2 branch May 22, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants