[CRE-491] Prepare relay/evm files to be moved to chainlink-evm#22650
Merged
Conversation
pavel-raykov
changed the title
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW
Prepares the EVM relay code for extraction to chainlink-evm by reducing test coupling to internal packages and exposing a constructor needed by quarantined tests that will remain in this repo.
Changes:
- Added a
keys.AddressListermock and refactoredevm_service_test.goto use it instead of keystore mocks. - Exported a config poller constructor variant so
config_poller_test.gocan move toevm_test(quarantine-friendly). - Updated
.mockery.yamlto generate the newAddressListermock.
Areas requiring scrupulous human review:
- Public surface changes in
core/services/relay/evm/config_poller.go(exported constructor) to ensure the intended API shape is correct for long-term maintenance and extraction. - Mockery configuration correctness for
chainlink-evm/pkg/keys(since it targets an external module interface).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| core/services/relay/evm/types/mocks/address_lister.go | Adds a mockery-generated mock for keys.AddressLister to decouple tests from keystore. |
| core/services/relay/evm/evm_service_test.go | Replaces keystore-based enabled-address mocking with AddressLister mocking. |
| core/services/relay/evm/config_poller.go | Exports a constructor needed by evm_test-package tests. |
| core/services/relay/evm/config_poller_test.go | Moves test to evm_test and updates references to exported APIs. |
| .mockery.yaml | Configures mockery generation for chainlink-evm/pkg/keys.AddressLister. |
Files not reviewed (1)
- core/services/relay/evm/types/mocks/address_lister.go: Language not supported
|
jmank88
approved these changes
May 26, 2026
ChrisAmora
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewConfigPollerWithParamsinstead of the privatenewConfigPoller)core/services/keystoreby mocking directly the underlying AddressLister from chainlink-evm instead of the custom keyStoreMock based on Eth's service mock)