Skip to content

chore: move aptos contract metadata view to ccip/view/aptos#22659

Merged
jkongie merged 1 commit into
developfrom
move-aptos-contract-metadata-view
May 28, 2026
Merged

chore: move aptos contract metadata view to ccip/view/aptos#22659
jkongie merged 1 commit into
developfrom
move-aptos-contract-metadata-view

Conversation

@jkongie
Copy link
Copy Markdown
Contributor

@jkongie jkongie commented May 27, 2026

This struct is only used by CCIP, so it makes sense to move it to the ccip/view/aptos package.

This struct is only used by CCIP, so it makes sense to move it to the
`ccip/view/aptos` package.
@github-actions
Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@cl-sonarqube-production
Copy link
Copy Markdown

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 27, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestCCIPReader_Nonces The test failed due to a 'replacement transaction underpriced' error during the CCIP reader nonce test. Logs ↗︎

View Full Report ↗︎Docs

@jkongie jkongie marked this pull request as ready for review May 28, 2026 10:05
Copilot AI review requested due to automatic review settings May 28, 2026 10:05
@jkongie jkongie requested review from a team as code owners May 28, 2026 10:05
@jkongie jkongie enabled auto-merge May 28, 2026 10:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Relocates the Aptos ContractMetaData struct from deployment/common/view/aptos into deployment/ccip/view/aptos since it is only consumed by CCIP views, and updates all embedding sites and constructor calls to use the new local type.

Changes:

  • Adds contract_metadata.go defining ContractMetaData in the ccip/view/aptos package.
  • Removes the aptosCommon import and replaces embedded/constructed aptosCommon.ContractMetaData references with the local ContractMetaData across CCIP Aptos view files.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
deployment/ccip/view/aptos/contract_metadata.go New file defining the relocated ContractMetaData struct.
deployment/ccip/view/aptos/ccip.go Drops aptosCommon import; updates embeds and struct literals to local type.
deployment/ccip/view/aptos/mcms.go Same migration to local ContractMetaData.
deployment/ccip/view/aptos/offramp.go Same migration to local ContractMetaData.
deployment/ccip/view/aptos/onramp.go Same migration to local ContractMetaData.
deployment/ccip/view/aptos/router.go Same migration to local ContractMetaData.
deployment/ccip/view/aptos/token.go Same migration to local ContractMetaData.
deployment/ccip/view/aptos/token_pool.go Same migration to local ContractMetaData.

Risk Rating: LOW — mechanical refactor moving a small struct between packages; no behavior change. The old deployment/common/view/aptos directory has been fully removed and no remaining references to it exist in the repo.

@jkongie jkongie added this pull request to the merge queue May 28, 2026
Merged via the queue into develop with commit 4615d67 May 28, 2026
311 of 313 checks passed
@jkongie jkongie deleted the move-aptos-contract-metadata-view branch May 28, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants