Add jitter for database polls to reduce 'stampeding herd' problem#3655
Merged
Add jitter for database polls to reduce 'stampeding herd' problem#3655
Conversation
samsondav
requested review from
RyanRHall,
j16r,
se3000,
spooktheducks and
topliceanu
as code owners
Contributor
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
topliceanu
previously approved these changes
Nov 18, 2020
core/utils/utils.go
Outdated
Contributor
There was a problem hiding this comment.
How do you feel about the name AddJitter() or WithJitter()
core/utils/utils_test.go
Outdated
Contributor
There was a problem hiding this comment.
I "think" the bounds are tighter here:
d := 10
//jitter := mrand.Intn(int(d) / 10)
jitter := [0, 1)
// jitter = jitter - (jitter / 2)
jitter = [0, 0.5)
// return time.Duration(int(d) + jitter)
d + jitter = [10, 10.5)
Contributor
Author
There was a problem hiding this comment.
Ah yes, you are right!
samsondav
force-pushed
the
stampeding_hurd
branch
from
e1ba3ca to
e4c610a
Compare
topliceanu
approved these changes
Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.