Use go:embed instead of packr

[makramkd]

Replace packr with Go 1.16's embed feature.

Here's a summary of the changes:

1. Use go:embed instead of packr.Box to embed the build assets of operator-ui into the chainlink binary.
2. In order to be able to use go:embed, we must have the assets available in the same folder as the module in which the go:embed directive is supplied. In this case, the assets must be available in core/web. Therefore, the webpack configuration was changed to output the compiled static assets (the HTML, JavaScript, and SVG files) in core/web instead of operator_ui/dist.
3. As a consequence of doing (2), we need to update the chainlink dockerfile.

[github-actions]

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

[archseer]

Don't forget to remove it from the dependency list at the top of go.mod too so we stop downloading it

[makramkd]

Done!

[archseer]

You probably also need a go mod tidy now? There's still some references in go.sum

[makramkd]

This is odd, I still see packr in the go.sum even after I run a go mod tidy. Even after manually deleting those entries in go.sum and re-calling go mod tidy it still adds them back.

[makramkd]

Actually, another thing I noticed is that go mod tidy only removes some versions of a dependency from go.sum and not others. Not sure why that is. E.g godirwalk, godotenv, go-internal, and logrus still have entries in go.sum.

[makramkd]

So despite this being somewhat annoying, I think this is alright. The go.sum file basically just has hashes of modules at certain versions, and it does this to verify dependencies it downloaded (as a security feature). It doesn't mean that the dep will be downloaded though, so it's not dependency bloat. The go.mod file however is where deps are declared and that's the source of truth on what modules are required by the app.

[jkongie]

I don’t believe so. It runs a node werver for local development, but if it does rely on the same build path, you could make local dev load from the original path

…

On Fri, 26 Nov 2021 at 9:39 PM, Makram Kamaleddine ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In core/web/middleware.go <https://urldefense.com/v3/__https://github.com/smartcontractkit/chainlink/pull/5529*discussion_r757503770__;Iw!!PuLkPvyT3vEAvUES!VOVLZFfJmHDekgNkv-mUw5-o3JlIVslj0647rqQho-n5aUUVG0Ob1jRDU9NXDzpbq81EEg$> : > "github.com/smartcontractkit/chainlink/core/logger" ) +// Go's new embed feature doesn't allow us to embed things outside of the current module. +// To get around this, we basically need to copy over the assets to this module's directory If we output it to core/web, will that break things like running the frontend server separately? Or will that end up re-compiling assets anyway (without minifying probably, to aid in debugging)? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/smartcontractkit/chainlink/pull/5529*discussion_r757503770__;Iw!!PuLkPvyT3vEAvUES!VOVLZFfJmHDekgNkv-mUw5-o3JlIVslj0647rqQho-n5aUUVG0Ob1jRDU9NXDzpbq81EEg$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAAPDCXIEBQP7QAKESYMLL3UN6EZRANCNFSM5IZSYVDA__;!!PuLkPvyT3vEAvUES!VOVLZFfJmHDekgNkv-mUw5-o3JlIVslj0647rqQho-n5aUUVG0Ob1jRDU9NXDzoA1vQ9Xg$> .

[archseer]

Oh, since the contracts are no longer embedded, I wonder if we could move

chainlink/.github/workflows/continuous-integration-workflow.yml

Lines 64 to 67 in 80ce471

	- name: Compile all contracts
	run: ./contracts/scripts/native_solc_compile_all
	- name: Verify local solc binaries
	run: ./tools/ci/check_solc_hashes

under the solidity workflow.

[samsondav]

Nice work

[archseer]

Should we still do this in the Solidity workflow? It currently only runs the tests

[makramkd]

I can move this there, since we don't do it there.

[archseer]

Great work! 🎉