Merged
Conversation
begmaroman
requested review from
alexroan,
connorwstein and
se3000
as code owners
Contributor
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
RyanRHall
reviewed
Dec 14, 2021
| uint256 nextTick | ||
| ) | ||
| { | ||
| if (!s_activeCronJobIDs.contains(id)) { |
Contributor
There was a problem hiding this comment.
can we add a test for this reversion as well?
Contributor
Author
There was a problem hiding this comment.
We already have a test for this on 352 line.
RyanRHall
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.