feat!: delete Link state views#68
Merged
Merged
Conversation
BREAKING CHANGE: Removes the LinkToken and StaticLinkToken state views from the public API.
|
👋 jkongie, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the LinkToken and StaticLinkToken “state view” types from the module’s public API (breaking change), along with their associated view generation helpers and tests.
Changes:
- Deleted the
LinkTokenView/GenerateLinkTokenViewimplementation. - Deleted the
StaticLinkTokenView/GenerateStaticLinkTokenViewimplementation. - Removed unit/integration tests that exercised those view generators.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/contract/link/view/v10/static_link_token.go | Removed the StaticLinkTokenView type and generator from the public API. |
| pkg/contract/link/view/v10/static_link_token_test.go | Removed tests covering GenerateStaticLinkTokenView. |
| pkg/contract/link/view/v10/link_token.go | Removed the LinkTokenView type and generator from the public API. |
| pkg/contract/link/view/v10/link_token_test.go | Removed tests covering GenerateLinkTokenView (including zk-specific test). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
ChrisAmora
approved these changes
May 25, 2026
ChrisAmora
pushed a commit
that referenced
this pull request
May 29, 2026
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2026-05-29) ### ⚠ BREAKING CHANGES * Deletes the ApproveToken helper and related tests. * Removes the Solana MCMS state views from the public API. * Removes the LinkToken and StaticLinkToken state views from the public API. * Moves version constants out of the public API and into internal. * Remove `ValidateSelectorsInEnvironment` method from `pkg/cldfutil/selectors.go`. ### Features * delete ApproveToken helper ([#70](#70)) ([83f59e7](83f59e7)) * delete Link state views ([#68](#68)) ([d5f643b](d5f643b)) * link refactor ([#71](#71)) ([177dbc5](177dbc5)) * remove Solana MCMS state views ([#69](#69)) ([eb948dd](eb948dd)) * remove ValidateSelectorsInEnvironment method ([#61](#61)) ([72f431f](72f431f)) ### Bug Fixes * move contract version to internal package ([#64](#64)) ([936a00b](936a00b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removes the LinkToken and StaticLinkToken state views from the public API.