feat: link refactor#71
Merged
Merged
Conversation
ChrisAmora
force-pushed
the
feat/link-v2
branch
2 times, most recently
from
989ac55 to
8752a72
Compare
Collaborator
|
You may want to leave the existing changesets instead of replacing them. Think about an easy to use directory structure that would be intuitive for users to use. Perhaps something link We will also want to consider how to handle different chains |
ChrisAmora
force-pushed
the
feat/link-v2
branch
2 times, most recently
from
328e048 to
30dcf46
Compare
Contributor
Author
Yeah, changed the structure a little bit too. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors LINK token deployment and transfer test setup to align with the newer CLDF deployment flow, resolving contract addresses via the DataStore (instead of the legacy AddressBook) and introducing reusable LINK token changesets/operations.
Changes:
- Added new LINK token deployment operations (EVM burn/mint + EVM static + Solana SPL) and a multi-chain
DeployLinkTokenChangesetthat persists results to theDataStore. - Added
TransferLinkTokenChangesetfor building an MCMS timelock proposal to transfer LINK using addresses resolved from theDataStore. - Updated legacy MCMS tests to use the new LINK deployment changeset and to resolve LINK token addresses from the
DataStore.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tokens/link/operations/deploy.go | Introduces EVM/Solana LINK token deploy operations used by the new changeset flow. |
| tokens/link/changesets/validation.go | Adds shared helpers for type/version selection, selector-family validation, and datastore address ref persistence. |
| tokens/link/changesets/deploy_link_token.go | New LINK deployment changeset that deploys per-chain and writes resulting addresses to a datastore output. |
| tokens/link/changesets/deploy_link_token_test.go | Adds tests for the new LINK deployment changeset behavior (variants, family validation, existing-state blocking). |
| tokens/link/changesets/transfer_link_token.go | New changeset to build an MCMS timelock proposal for transferring LINK based on datastore-resolved addresses. |
| tokens/link/changesets/transfer_link_token_test.go | Adds tests for transfer preconditions, proposal building, and ValidUntil behavior. |
| legacy/mcms/changesets/transfer_to_mcms_with_timelock_test.go | Updates legacy MCMS timelock transfer tests to deploy LINK via new changeset and resolve via datastore. |
| legacy/mcms/changesets/set_config_mcms_test.go | Updates legacy MCMS config test setup to use the new LINK changeset import + invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChrisAmora
force-pushed
the
feat/link-v2
branch
2 times, most recently
from
f78146c to
33355b0
Compare
gustavogama-cll
previously approved these changes
May 26, 2026
gustavogama-cll
approved these changes
May 27, 2026
|
ChrisAmora
pushed a commit
that referenced
this pull request
May 29, 2026
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2026-05-29) ### ⚠ BREAKING CHANGES * Deletes the ApproveToken helper and related tests. * Removes the Solana MCMS state views from the public API. * Removes the LinkToken and StaticLinkToken state views from the public API. * Moves version constants out of the public API and into internal. * Remove `ValidateSelectorsInEnvironment` method from `pkg/cldfutil/selectors.go`. ### Features * delete ApproveToken helper ([#70](#70)) ([83f59e7](83f59e7)) * delete Link state views ([#68](#68)) ([d5f643b](d5f643b)) * link refactor ([#71](#71)) ([177dbc5](177dbc5)) * remove Solana MCMS state views ([#69](#69)) ([eb948dd](eb948dd)) * remove ValidateSelectorsInEnvironment method ([#61](#61)) ([72f431f](72f431f)) ### Bug Fixes * move contract version to internal package ([#64](#64)) ([936a00b](936a00b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how LINK token deployment is handled in the MCMS changeset tests and introduces a new, reusable LINK token deployment changeset in the codebase. The main changes include switching to the new
DeployLinkTokenChangesetfor both EVM and Solana chains, updating test code to use the new data store pattern for contract lookups.