Fix: --limits none now fully disables engine-level limit enforcement #375
Merged
Conversation
|
👋 ejacquier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
timothyF95
approved these changes
Apr 16, 2026
timothyF95
reviewed
Apr 16, 2026
| // Execution limits | ||
| cfg.ExecutionTimeout = maxDuration | ||
| cfg.ExecutionResponseLimit = maxSize | ||
| cfg.ExecutionConcurrencyLimit = maxInt |
Contributor
There was a problem hiding this comment.
nit: These limits seem quite excessive? A buggy workflow could OOM a test machine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--limits none was intended to disable all limit enforcement during simulation, but only suppressed CLI-side checks (WASM binary size, HTTP request/response
size). The engine itself still applied its built-in defaults from cresettings.Default — for example HTTPAction.CallLimit = 5 — because ResolveLimits("none")
returns nil and the WorkflowSettingsCfgFn callback skipped applyEngineLimits when simLimits == nil, leaving the engine to fall back to its own defaults.
This caused unexpected errors like cannot use 6, limit is 5 even when --limits none was explicitly passed.
Fix
cmd/workflow/simulate/limits.go — adds disableEngineLimits(cfg *cresettings.Workflows), which sets all engine limit fields to effectively unbounded values
(math.MaxInt32 for int/size fields, 24h for duration fields).
This covers all capability categories: execution, WASM, logging, HTTPAction, ConfidentialHTTP, Consensus, ChainWrite, ChainRead, and Secrets.
cmd/workflow/simulate/simulate.go — in the WorkflowSettingsCfgFn callback, adds an else if inputs.LimitsPath == "none" branch that calls disableEngineLimits(cfg), so the engine receives the uncapped values instead of falling back to its built-in defaults.