Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions cmd/workflow/simulate/limits.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@ import (
_ "embed"
"encoding/json"
"fmt"
"math"
"os"
"strings"
"time"

"github.com/smartcontractkit/chainlink-common/pkg/config"
"github.com/smartcontractkit/chainlink-common/pkg/settings"
"github.com/smartcontractkit/chainlink-common/pkg/settings/cresettings"
)

Expand Down Expand Up @@ -93,6 +97,70 @@ func applyEngineLimits(cfg *cresettings.Workflows, limits *SimulationLimits) {
// NOTE: ChainAllowed is NOT overridden — simulation keeps allow-all
}

// disableEngineLimits sets all engine limit fields to very high values,
// effectively disabling limit enforcement when --limits none is used.
func disableEngineLimits(cfg *cresettings.Workflows) {
maxInt := settings.Setting[int]{DefaultValue: math.MaxInt32}
maxSize := settings.Setting[config.Size]{DefaultValue: math.MaxInt32}
maxDuration := settings.Setting[time.Duration]{DefaultValue: 24 * time.Hour}

// Execution limits
cfg.ExecutionTimeout = maxDuration
cfg.ExecutionResponseLimit = maxSize
cfg.ExecutionConcurrencyLimit = maxInt
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: These limits seem quite excessive? A buggy workflow could OOM a test machine


// Capability limits
cfg.CapabilityConcurrencyLimit = maxInt
cfg.CapabilityCallTimeout = maxDuration
cfg.SecretsConcurrencyLimit = maxInt

// Trigger limits
cfg.TriggerRegistrationsTimeout = maxDuration
cfg.TriggerEventQueueLimit = maxInt
cfg.TriggerEventQueueTimeout = maxDuration
cfg.TriggerSubscriptionTimeout = maxDuration
cfg.TriggerSubscriptionLimit = maxInt

// WASM limits
cfg.WASMMemoryLimit = maxSize
cfg.WASMBinarySizeLimit = maxSize
cfg.WASMCompressedBinarySizeLimit = maxSize
cfg.WASMConfigSizeLimit = maxSize
cfg.WASMSecretsSizeLimit = maxSize

// Log limits
cfg.LogLineLimit = maxSize
cfg.LogEventLimit = maxInt

// HTTPAction limits
cfg.HTTPAction.CallLimit = maxInt
cfg.HTTPAction.CacheAgeLimit = maxDuration
cfg.HTTPAction.ConnectionTimeout = maxDuration
cfg.HTTPAction.RequestSizeLimit = maxSize
cfg.HTTPAction.ResponseSizeLimit = maxSize

// ConfidentialHTTP limits
cfg.ConfidentialHTTP.CallLimit = maxInt
cfg.ConfidentialHTTP.ConnectionTimeout = maxDuration
cfg.ConfidentialHTTP.RequestSizeLimit = maxSize
cfg.ConfidentialHTTP.ResponseSizeLimit = maxSize

// Consensus limits
cfg.Consensus.CallLimit = maxInt
cfg.Consensus.ObservationSizeLimit = maxSize

// ChainWrite limits
cfg.ChainWrite.TargetsLimit = maxInt
cfg.ChainWrite.ReportSizeLimit = maxSize

// ChainRead limits
cfg.ChainRead.CallLimit = maxInt
cfg.ChainRead.PayloadSizeLimit = maxSize

// Secrets limits
cfg.Secrets.CallLimit = maxInt
}

// HTTPRequestSizeLimit returns the HTTP action request size limit in bytes.
func (l *SimulationLimits) HTTPRequestSizeLimit() int {
return int(l.Workflows.HTTPAction.RequestSizeLimit.DefaultValue)
Expand Down
2 changes: 2 additions & 0 deletions cmd/workflow/simulate/simulate.go
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,8 @@ func run(
// Apply simulation limits to engine-level settings when --limits is set
if simLimits != nil {
applyEngineLimits(cfg, simLimits)
} else if inputs.LimitsPath == "none" {
disableEngineLimits(cfg)
}
// Always allow all chains in simulation, overriding any chain restrictions from limits
cfg.ChainAllowed = commonsettings.PerChainSelector(
Expand Down
Loading