feat: add UI warning for EnvironmentSet values#415
Merged
Conversation
timothyF95
reviewed
May 6, 2026
timothyF95
reviewed
May 6, 2026
ejacquier
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVSVCS-4904
This pull request enhances environment configuration handling in
internal/environments/environments.goby improving how environment variables are loaded and introducing clearer feedback for users when environment settings are overridden or missing. It also ensures warnings are only shown once per process.Key improvements:
Environment variable handling and user feedback:
EnvironmentSet, reducing code duplication and making the logic clearer. Now, each variable is explicitly loaded and checked before assignment.ui.Warning) when specific environment variables are set, or when an unknown environment is requested. This helps users understand which configuration is active and if any overrides are in effect. Warnings are shown only once per process usingsync.Once.