Skip to content

feat: add UI warning for EnvironmentSet values #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anirudhwarrier merged 2 commits into from
May 7, 2026
Merged

feat: add UI warning for EnvironmentSet values #415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e2b8a5
feat: add UI warning for EnvironmentSet values
anirudhwarrier May 6, 2026
53fa094
simplify switch case
anirudhwarrier May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 90 additions & 34 deletions internal/environments/environments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@ import (
"fmt"
"os"
"strings"
"sync"

"gopkg.in/yaml.v2"

"github.com/smartcontractkit/cre-cli/internal/ui"
)

const (
Expand All @@ -24,7 +27,9 @@ const (
EnvVarDonFamily = "CRE_CLI_DON_FAMILY"
EnvVarSecretsOrgOwned = "CRE_CLI_SECRETS_ORG_OWNED"

DefaultEnv = "PRODUCTION"
DefaultEnv = "PRODUCTION"
StagingEnv = "STAGING"
DevelopmentEnv = "DEVELOPMENT"
)

//go:embed environments.yaml
Expand Down Expand Up @@ -78,46 +83,97 @@ func loadEmbeddedEnvironmentFile() (*fileFormat, error) {
return &ff, nil
}

var newEnvironmentSetWarningsOnce sync.Once

func NewEnvironmentSet(ff *fileFormat, envName string) *EnvironmentSet {
set, ok := ff.Envs[envName]
if !ok {
set = ff.Envs[DefaultEnv]
}
set.EnvName = envName
if v := os.Getenv(EnvVarAuthBase); v != "" {
set.AuthBase = v
}
if v := os.Getenv(EnvVarClientID); v != "" {
set.ClientID = v
}
if v := os.Getenv(EnvVarGraphQLURL); v != "" {
set.GraphQLURL = v
}
if v := os.Getenv(EnvVarAudience); v != "" {
set.Audience = v
}
if v := os.Getenv(EnvVarVaultGatewayURL); v != "" {
set.GatewayURL = v
}
if v := os.Getenv(EnvVarWorkflowRegistryChainExplorerURL); v != "" {
set.WorkflowRegistryChainExplorerURL = v
}
// TODO for each contract - check if it's really a contract, not an EOA
if v := os.Getenv(EnvVarWorkflowRegistryAddress); v != "" {
set.WorkflowRegistryAddress = v
}

if v := os.Getenv(EnvVarWorkflowRegistryChainName); v != "" {
set.WorkflowRegistryChainName = v
}
authBase := os.Getenv(EnvVarAuthBase)
clientID := os.Getenv(EnvVarClientID)
graphqlURL := os.Getenv(EnvVarGraphQLURL)
audience := os.Getenv(EnvVarAudience)
gatewayURL := os.Getenv(EnvVarVaultGatewayURL)
wrChainExplorerURL := os.Getenv(EnvVarWorkflowRegistryChainExplorerURL)
// TODO for workflow registry contract - check if it's really a contract, not an EOA
wrAddress := os.Getenv(EnvVarWorkflowRegistryAddress)
wrChainName := os.Getenv(EnvVarWorkflowRegistryChainName)
donFamily := os.Getenv(EnvVarDonFamily)
secretsOrgOwned := os.Getenv(EnvVarSecretsOrgOwned)

if v := os.Getenv(EnvVarDonFamily); v != "" {
set.DonFamily = v
}

if v := os.Getenv(EnvVarSecretsOrgOwned); v != "" {
set.SecretsOrgOwned = strings.EqualFold(v, "true")
}
set.EnvName = envName
if authBase != "" {
set.AuthBase = authBase
}
if clientID != "" {
set.ClientID = clientID
}
if graphqlURL != "" {
set.GraphQLURL = graphqlURL
}
if audience != "" {
set.Audience = audience
}
if gatewayURL != "" {
set.GatewayURL = gatewayURL
}
if wrChainExplorerURL != "" {
set.WorkflowRegistryChainExplorerURL = wrChainExplorerURL
}
if wrAddress != "" {
set.WorkflowRegistryAddress = wrAddress
}
if wrChainName != "" {
set.WorkflowRegistryChainName = wrChainName
}
if donFamily != "" {
set.DonFamily = donFamily
}
if secretsOrgOwned != "" {
set.SecretsOrgOwned = strings.EqualFold(secretsOrgOwned, "true")
}

newEnvironmentSetWarningsOnce.Do(func() {
switch envName {
case DefaultEnv:
case DevelopmentEnv, StagingEnv:
ui.Warning(fmt.Sprintf("%s set, using %s environment", EnvVarEnv, envName))
default:
ui.Warning(fmt.Sprintf("Environment %s not found, defaulting to %s", envName, DefaultEnv))
}
if authBase != "" {
Comment thread
anirudhwarrier marked this conversation as resolved.
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarAuthBase, authBase))
}
if clientID != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarClientID, clientID))
}
if graphqlURL != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarGraphQLURL, graphqlURL))
}
if audience != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarAudience, audience))
}
if gatewayURL != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarVaultGatewayURL, gatewayURL))
}
if wrChainExplorerURL != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarWorkflowRegistryChainExplorerURL, wrChainExplorerURL))
}
if wrAddress != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarWorkflowRegistryAddress, wrAddress))
}
if wrChainName != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarWorkflowRegistryChainName, wrChainName))
}
if donFamily != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarDonFamily, donFamily))
}
if secretsOrgOwned != "" {
ui.Warning(fmt.Sprintf("%s set, using %s", EnvVarSecretsOrgOwned, secretsOrgOwned))
}
})

return &set
}
Expand Down
Loading