Add Linux asset suffix handling and tests#525
Merged
Conversation
- Introduced functions to determine the appropriate asset suffix based on glibc version for Linux. - Added tests for parsing glibc versions and verifying the correct asset suffix. - Updated installation script to utilize the new suffix logic. - Enhanced the getAssetName function to include the Linux suffix in asset naming. This change improves compatibility for older Linux distributions.
|
🚀 Preview Build Artifacts You can download the preview builds for this PR from the following URL: https://github.com/smartcontractkit/cre-cli/actions/runs/29078785445 Note: These are preview builds and are not signed. |
|
🚀 Preview Build Artifacts You can download the preview builds for this PR from the following URL: https://github.com/smartcontractkit/cre-cli/actions/runs/29079756583 Note: These are preview builds and are not signed. |
|
🚀 Preview Build Artifacts You can download the preview builds for this PR from the following URL: https://github.com/smartcontractkit/cre-cli/actions/runs/29092431799 Note: These are preview builds and are not signed. |
timothyF95
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVSVCS-5549
Summary
ldd --versionand using the_ldd2-35asset suffix (e.g. Ubuntu 22.04).cre update: downloadscre_linux_{arch}_ldd2-35.tar.gzand matching.sigon older glibc; default asset unchanged on 2.36+.install/install.sh: same detection for one-line installs; prints a message when the legacy build is selected.Test plan
install/linux_asset_suffix_test.shin CI_ldd2-35, Ubuntu 24.04 → defaultcre update/bash install/install.shon Ubuntu 22.04 amd64 link