Fail closed on unparseable semver during self-update - #543
Merged
Conversation
If either the current or latest version cannot be parsed as semver, the update now aborts instead of proceeding, preventing unintended downgrades or version jumps. Add a --force/-f flag to override and update tests.
anirudhwarrier
marked this pull request as ready for review
July 23, 2026 09:36
anirudhwarrier
enabled auto-merge
July 23, 2026 11:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVSVCS-5289
Fail closed on unparseable semver during self-update
Problem:
cre update previously proceeded with the update whenever it couldn't parse the current or latest version as semver (fail-open), allowing unintended downgrades or version jumps. Flagged by security review.
Fix: