Skip to content

Data Feeds: Risk logic update, Address visibility changes#3783

Merged
dev-dist merged 2 commits into
mainfrom
aptos-feed-categories-fix
May 15, 2026
Merged

Data Feeds: Risk logic update, Address visibility changes#3783
dev-dist merged 2 commits into
mainfrom
aptos-feed-categories-fix

Conversation

@dev-dist
Copy link
Copy Markdown
Collaborator

This pull request refactors the logic for determining and displaying feed risk categories and address visibility in the data feeds UI. The main improvements include a more consistent and centralized approach to risk category resolution (including deprecation status), and a new mechanism for hiding specific feed addresses in the UI based on either product subtype or explicit overrides.

Feed risk category resolution and UI improvements:

  • The logic for determining a feed's final risk category has been centralized. Now, the database risk status is used when available; if not, "deprecating" is inferred from the feed's shutdown date; otherwise, null is returned. This ensures more accurate and predictable category handling across the app. [1] [2] [3] [4] [5] [6]
  • The FeedRequest type and related data flows have been updated to include an optional shutdownDate, allowing the deprecation status to be determined as part of the batch lookup process. [1] [2] [3]
  • The fallback logic for category assignment has been removed from the UI components; now, if neither a DB risk status nor a deprecation status is present, the final category is null.

Feed address visibility logic:

  • A new shouldHideAddress utility and a CONTACT_EMAIL_PROXY_ADDRESSES set have been introduced. This allows the UI to hide the contract address for feeds with productSubType === "calculatedPrice" or for specific proxy addresses listed in the override set. [1] [2] [3] [4] [5] [6] [7]
  • All table components now use the new shouldHideAddress logic, ensuring consistent address-hiding behavior for both calculated-price feeds and one-off exceptions. [1] [2] [3] [4] [5]

Minor UI and data handling fixes:

  • Improved null handling and normalization in category filtering to prevent errors when no final category is available. [1] [2] [3] [4]

These changes make the risk category and address display logic more robust, maintainable, and easier to extend for future requirements.

@dev-dist dev-dist requested a review from a team as a code owner May 15, 2026 15:09
@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
documentation Ready Ready Preview May 15, 2026 3:09pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

👋 dev-dist, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@dev-dist dev-dist enabled auto-merge (squash) May 15, 2026 15:36
@dev-dist dev-dist merged commit 7199fa6 into main May 15, 2026
27 checks passed
@dev-dist dev-dist deleted the aptos-feed-categories-fix branch May 15, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants