Skip to content

fix: fix issue with iterator for svc search#182

Merged
morenol merged 1 commit into
smartcorelib:developmentfrom
morenol:lmm/fix_typo
Oct 2, 2022
Merged

fix: fix issue with iterator for svc search#182
morenol merged 1 commit into
smartcorelib:developmentfrom
morenol:lmm/fix_typo

Conversation

@morenol

@morenol morenol commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

There is an issue with the iterator for SVC Search'

&& self.current_seed == self.svc_search_parameters.kernel.len()

should be

            && self.current_seed == self.svc_search_parameters.seed.len()

@morenol
morenol requested a review from Mec-iS as a code owner October 2, 2022 00:26
@morenol
morenol requested a review from montanalow October 2, 2022 00:26
@codecov-commenter

codecov-commenter commented Oct 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #182 (e1f9346) into development (f8210d0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #182      +/-   ##
===============================================
+ Coverage        84.58%   84.60%   +0.01%     
===============================================
  Files               86       86              
  Lines             9974     9973       -1     
===============================================
+ Hits              8437     8438       +1     
+ Misses            1537     1535       -2     
Impacted Files Coverage Δ
src/svm/svc.rs 87.93% <100.00%> (+0.22%) ⬆️
src/optimization/line_search.rs 92.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@morenol
morenol merged commit 12df301 into smartcorelib:development Oct 2, 2022
@morenol
morenol deleted the lmm/fix_typo branch October 2, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants