ci: run smartcore-benches against release commit (#407) - #409
Merged
Conversation
Add .github/workflows/release-bench.yml that triggers on release.published. It checks out smartcore-benches into a sibling directory and patches its Cargo.toml via [patch.crates-io] to use the local smartcore checkout (the release commit), then runs criterion + iai-callgrind benchmarks. Results are uploaded as artifacts. No cross-repo dispatch or PAT needed.
Mec-iS
force-pushed
the
ci-release-bench
branch
from
August 9, 2026 15:10
4c10a4d to
2e023d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated CI workflow that clones
smartcore-benchesinto the runner and runs its criterion + iai-callgrind benchmarks against the released smartcore code — all in-repo, no cross-repo dispatch or PAT needed. Scoped to releases per the focused ask (#407).Changes
.github/workflows/release-bench.ymlon: release: types: [published]smartcore-benches/directory).cargo/config.tomlwith[patch.crates-io] smartcore = { path = "../" }so the benches'smartcore = "0.6"dependency resolves to the local checkout instead of crates.iocargo bench --no-run)--output-format bencher→bench-output/criterion.json)iai_matmul,iai_ab,iai_svd,iai_cover_tree,iai_iterator_mut)release-benchmark-results, 90-day retention)No secrets, no PAT, no cross-repo dispatch
The benches run directly in the smartcore CI runner. The
[patch.crates-io]override repoints the benches' smartcore dependency to the already-checked-out release commit — no crates.io round-trip, norepository_dispatch, noBENCHES_DISPATCH_PATsecret.Verification
cargo fmt --all -- --check= 0cargo clippy --all-features -- -Drust-2018-idioms -Drust-2024-compatibility -Dwarnings= 0What this does NOT do (intentionally, per scope)
developmentpushes — that's the per-commit dispatch path (separate concern).Refs #407.