Fix SDL respond UNSUPPORTED_RESOURCE on SystemRequest (QUERY_APPS) #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ypostolov
requested review from
a user,
AKalinich-Luxoft,
APipko,
BSolonenko,
EKuliiev,
IGapchuk,
LitvinenkoIra,
LuxoftAKutsan and
SNiukalov
… is below version 4.0
Ypostolov
force-pushed
the
fix/SDL_must_respond_unsupported_resource
branch
from
0ba1811 to
68750b6
Compare
AKalinich-Luxoft
approved these changes
Aug 9, 2018
IGapchuk
approved these changes
Aug 9, 2018
|
|
||
| if (mobile_apis::RequestType::QUERY_APPS == request_type && | ||
| application_manager_.get_settings().max_supported_protocol_version() < | ||
| 4) { |
Contributor
There was a problem hiding this comment.
@Ypostolov 4 is like a magic number extract ti variable with comment
|
Can one of the admins verify this patch? |
EKuliiev
approved these changes
Aug 10, 2018
BSolonenko
approved these changes
Aug 20, 2018
SNiukalov
approved these changes
Sep 7, 2018
LitvinenkoIra
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2399
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Changes in PR are already covered within existing unit tests.
Summary
SDL respond UNSUPPORTED_RESOURCE on SystemRequest (QUERY_APPS) to mobile app in case SDL 4.0 feature is required to be ommited in implementation.
CLA