Skip to content

Fix SDL respond UNSUPPORTED_RESOURCE on SystemRequest (QUERY_APPS) #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iCollin merged 3 commits into from
Apr 16, 2021
Merged

Fix SDL respond UNSUPPORTED_RESOURCE on SystemRequest (QUERY_APPS) #2502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68750b6
SDL respond UNSUPPORTED_RESOURCE on SystemRequest (QUERY_APPS) if SDL…
Ypostolov Aug 8, 2018
3540848
answer review comments
Ypostolov Aug 10, 2018
2a44cae
Merge branch 'develop' into fix/SDL_must_respond_unsupported_resource
iCollin Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...ents/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/system_request.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,6 @@ void SystemRequest::Run() {
SendResponse(false, mobile_apis::Result::APPLICATION_NOT_REGISTERED);
return;
}

const mobile_apis::RequestType::eType request_type =
static_cast<mobile_apis::RequestType::eType>(
(*message_)[strings::msg_params][strings::request_type].asInt());
Expand Down Expand Up @@ -479,6 +478,15 @@ void SystemRequest::Run() {
return;
}

const uint16_t query_apps_min_version = 4;

if (mobile_apis::RequestType::QUERY_APPS == request_type &&
application_manager_.get_settings().max_supported_protocol_version() <
query_apps_min_version) {
SendResponse(false, mobile_apis::Result::UNSUPPORTED_RESOURCE);
return;
}

if (!file_system::IsFileNameValid(file_name) &&
mobile_apis::RequestType::ICON_URL != request_type) {
const std::string err_msg = "Sync file name contains forbidden symbols.";
Expand Down