Skip to content

sdl manager crashes when non-mandatory language is null#1209

Merged
bilal-alsharifi merged 2 commits intorelease/4.10-RCfrom
bugfix/null_language
Oct 25, 2019
Merged

sdl manager crashes when non-mandatory language is null#1209
bilal-alsharifi merged 2 commits intorelease/4.10-RCfrom
bugfix/null_language

Conversation

@BrettyWhite
Copy link
Copy Markdown
Contributor

Sdl manager crashes if language is null in the RAIR. THis param is optional, therefore it should not crash

CLA

@BrettyWhite BrettyWhite self-assigned this Oct 24, 2019
@bilal-alsharifi
Copy link
Copy Markdown
Contributor

I think that should be updated for javaSE too

@bilal-alsharifi bilal-alsharifi merged commit 90d6cf1 into release/4.10-RC Oct 25, 2019
@bilal-alsharifi bilal-alsharifi deleted the bugfix/null_language branch October 25, 2019 13:56
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 25, 2019

Codecov Report

Merging #1209 into release/4.10-RC will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release/4.10-RC   #1209      +/-   ##
====================================================
+ Coverage              47.06%   47.1%   +0.03%     
  Complexity              4327    4327              
====================================================
  Files                    481     481              
  Lines                  23475   23475              
  Branches                2683    2683              
====================================================
+ Hits                   11049   11057       +8     
+ Misses                 11760   11750      -10     
- Partials                 666     668       +2
Impacted Files Coverage Δ Complexity Δ
...smartdevicelink/encoder/VirtualDisplayEncoder.java 28.97% <0%> (+4.54%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc73da0...4a4622e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants