Bugfix/issue 1276#1287
Merged
bilal-alsharifi merged 9 commits intodevelopfrom Mar 10, 2020
Merged
Conversation
added 8 commits
February 27, 2020 10:10
…_suite into bugfix/issue_1276
Codecov Report
@@ Coverage Diff @@
## develop #1287 +/- ##
=============================================
+ Coverage 47.41% 47.45% +0.03%
- Complexity 4371 4375 +4
=============================================
Files 483 483
Lines 23677 23677
Branches 2733 2733
=============================================
+ Hits 11227 11235 +8
+ Misses 11762 11755 -7
+ Partials 688 687 -1
|
… passes a ready state to allow sdlManager to start baseFileManger line 163 : "file list could not be received. assume that setting can work and allow SDLManager to start"
bilal-alsharifi
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1276
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
Fixed unit test for FileManagerTest
Bug Fixes
CLA