Skip to content

Bugfix/issue 1276#1287

Merged
bilal-alsharifi merged 9 commits intodevelopfrom
bugfix/issue_1276
Mar 10, 2020
Merged

Bugfix/issue 1276#1287
bilal-alsharifi merged 9 commits intodevelopfrom
bugfix/issue_1276

Conversation

@JulianKast
Copy link
Copy Markdown
Contributor

@JulianKast JulianKast commented Feb 27, 2020

Fixes #1276

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Summary

Fixed unit test for FileManagerTest

Bug Fixes
  • Fixed unit test for FileManagerTest

CLA

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2020

Codecov Report

Merging #1287 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1287      +/-   ##
=============================================
+ Coverage      47.41%   47.45%   +0.03%     
- Complexity      4371     4375       +4     
=============================================
  Files            483      483              
  Lines          23677    23677              
  Branches        2733     2733              
=============================================
+ Hits           11227    11235       +8     
+ Misses         11762    11755       -7     
+ Partials         688      687       -1     
Impacted Files Coverage Δ Complexity Δ
...tdevicelink/managers/audio/AudioDecoderCompat.java 73.33% <0.00%> (+3.33%) 3.00% <0.00%> (ø%) ⬆️
...smartdevicelink/managers/file/BaseFileManager.java 66.47% <0.00%> (+3.52%) 27.00% <0.00%> (+4.00%) ⬇️

… passes a ready state to allow sdlManager to start

baseFileManger line 163 :  "file list could not be received. assume that setting can work and allow SDLManager to start"
@bilal-alsharifi bilal-alsharifi merged commit 0228f10 into develop Mar 10, 2020
@bilal-alsharifi bilal-alsharifi deleted the bugfix/issue_1276 branch March 10, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants