Add overwrite property#1303
Merged
bilal-alsharifi merged 14 commits intodevelopfrom Mar 11, 2020
Merged
Conversation
added 8 commits
March 4, 2020 15:55
…nstructor to set overwrite property
…tors and added it to the top of the classes
Codecov Report
@@ Coverage Diff @@
## develop #1303 +/- ##
=============================================
+ Coverage 47.55% 47.56% +<.01%
- Complexity 4389 4391 +2
=============================================
Files 488 488
Lines 23727 23735 +8
Branches 2735 2737 +2
=============================================
+ Hits 11284 11290 +6
Misses 11755 11755
- Partials 688 690 +2
|
bilal-alsharifi
suggested changes
Mar 10, 2020
added 3 commits
March 11, 2020 10:05
… property in uploadFiles and uploadFile
bilal-alsharifi
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1302
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Added unit test to test file not overwriting itself in BaseFileManager.uploadfiles as well as BaseFileManager.uploadFiles
Core Tests
Tested using manticore.
Summary
Added overwrite property to SdlFile in Android and JavaSE, added logic to baseFileManager.java to handle the overwrite property when uploading files.
Overwrite property is always set to true, in next major release to align with IOS we need to change it to false
To test I recommend after uploading one file to set the SdlFIle's overwrite property to false and upload it the second time in the completion listener's onComplete of the first upload to verify that the file has uploaded before it tries to upload it again. Ex:
Enhancements
CLA