Add Override Equals method to softButtonObject#1307
Merged
bilal-alsharifi merged 15 commits intodevelopfrom Mar 19, 2020
Merged
Add Override Equals method to softButtonObject#1307bilal-alsharifi merged 15 commits intodevelopfrom
bilal-alsharifi merged 15 commits intodevelopfrom
Conversation
added 8 commits
March 12, 2020 10:34
Codecov Report
@@ Coverage Diff @@
## develop #1307 +/- ##
=============================================
+ Coverage 47.56% 47.60% +0.03%
- Complexity 4391 4404 +13
=============================================
Files 488 488
Lines 23735 23754 +19
Branches 2737 2749 +12
=============================================
+ Hits 11290 11308 +18
+ Misses 11755 11753 -2
- Partials 690 693 +3
|
bilal-alsharifi
suggested changes
Mar 12, 2020
added 6 commits
March 13, 2020 10:17
bilal-alsharifi
approved these changes
Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1257
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Added testSoftButtonEq() and testSoftButtonStateEq() to SoftButtonManagerTests and testSdlFIleEq() to FileManagerTest
Core Tests
Tested using manticore
Summary
Added a method in SdlFile in android and JavaSE, softButtonObjects, and SoftButtonState that overrides their equals methods. The new equals methods compare the objects variables instead of their memory address.
Enhancements
CLA