Align SystemCapabilityManager with iOS (part3)#1321
Merged
bilal-alsharifi merged 18 commits intodevelopfrom Apr 9, 2020
Merged
Align SystemCapabilityManager with iOS (part3)#1321bilal-alsharifi merged 18 commits intodevelopfrom
bilal-alsharifi merged 18 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1321 +/- ##
=============================================
- Coverage 47.60% 47.56% -0.05%
Complexity 4403 4403
=============================================
Files 488 488
Lines 23757 23761 +4
Branches 2749 2751 +2
=============================================
- Hits 11310 11301 -9
- Misses 11753 11766 +13
Partials 694 694
|
bilal-alsharifi
changed the title
joeljfischer
suggested changes
Apr 2, 2020
Contributor
Author
|
@joeljfischer The |
joeygrover
reviewed
Apr 8, 2020
joeygrover
reviewed
Apr 8, 2020
joeygrover
reviewed
Apr 8, 2020
joeygrover
reviewed
Apr 8, 2020
joeygrover
reviewed
Apr 8, 2020
joeygrover
reviewed
Apr 8, 2020
joeygrover
reviewed
Apr 8, 2020
…/SdlManager.java Co-Authored-By: Joey Grover <joeygrover@gmail.com>
…/video/VideoStreamManager.java Co-Authored-By: Joey Grover <joeygrover@gmail.com>
# Conflicts: # android/sdl_android/src/androidTest/java/com/smartdevicelink/test/proxy/SystemCapabilityManagerTests.java # android/sdl_android/src/main/java/com/smartdevicelink/managers/SdlManager.java # android/sdl_android/src/main/java/com/smartdevicelink/managers/video/VideoStreamManager.java
joeygrover
approved these changes
Apr 9, 2020
joeljfischer
approved these changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1324
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Added new unit tests to test getting capabilities on different HMI levels and confirm that
GetSystemCapabilityrequest doesn't get sent out on HMILevelNONECore Tests
Did the following test on both Sync 3.2 and Core 6.0:
getCapablity()for a not cached capability on HMINONEand confirmonError()is calledgetCapablity()for a not cached capability on HMIFULLand confirmGetSystemCapbalbityrequest is sent to Core and the capability is received correctlyScreenManagerand make sure it gets theDISPLAYScapability correctly and works well with no errors inlogcatVideoStramingcapability correctly and works well with no errors inlogcatSummary
This PR updates
SystemCapabilityManagerto align with iOS:GetSystemCapabilityif the app is already subscribed to the capability (since all the updated values will be received via notifications).GetSystemCapabilityrequests if hmilevel isNONECLA