Use LifecycleManager in Android#1366
Merged
JulianKast merged 31 commits intodevelopfrom Jun 12, 2020
Merged
Conversation
# Conflicts: # android/sdl_android/src/main/java/com/smartdevicelink/managers/SdlManager.java # base/src/main/java/com/smartdevicelink/managers/BaseSdlManager.java # javaSE/src/main/java/com/smartdevicelink/managers/SdlManager.java
Codecov Report
@@ Coverage Diff @@
## develop #1366 +/- ##
=============================================
- Coverage 47.52% 46.01% -1.52%
- Complexity 4441 4461 +20
=============================================
Files 489 494 +5
Lines 23972 24905 +933
Branches 2775 2954 +179
=============================================
+ Hits 11392 11459 +67
- Misses 11882 12734 +852
- Partials 698 712 +14
|
bilal-alsharifi
changed the title
JulianKast
requested changes
Jun 11, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1365
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Unit tests have been updated to use
LifecycleManagerinstead ofSdlProxyBaseCore Tests
It is preferred to run most of the basic tests to make sure the new
LifecycleManageris working as expected:Core version / branch / commit hash / module tested against: 6.1.0
HMI name / version / branch / commit hash / module tested against: Generic HMI 0.8.0
Summary
This PR includes the following changes:
LifecylceManagerto Android and updateSdlManagerto use the newLifecylceManagerLifecylceManagerin bothAndroidandJavaSEto put most of the common logic inBaseLifecylceManagerSdlManagerin bothAndroidandJavaSEto put most of the common logic inBaseSdlManagerCLA