JavaSE - Add SdlFile constructor that takes URI#1470
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1470 +/- ##
=============================================
+ Coverage 46.95% 46.97% +0.01%
Complexity 4973 4973
=============================================
Files 537 537
Lines 27360 27360
Branches 3376 3376
=============================================
+ Hits 12848 12851 +3
+ Misses 13590 13589 -1
+ Partials 922 920 -2
|
RHenigan
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1469
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Core Tests
This code snippet can be used to test uploading a file using URI:
Core version: Core 6.1.0 / Generic HMI
Summary
This PR Adds
SdlFileconstructor that takesURIto the JavaSE library to align with AndroidCLA