Skip to content

Fix Lint Warnings#1491

Merged
RHenigan merged 27 commits intodevelopfrom
feature/fix_lint_warnings
Sep 14, 2020
Merged

Fix Lint Warnings#1491
RHenigan merged 27 commits intodevelopfrom
feature/fix_lint_warnings

Conversation

@bilal-alsharifi
Copy link
Copy Markdown
Contributor

@bilal-alsharifi bilal-alsharifi commented Sep 9, 2020

Fixes #1306

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE

Summary

This PR fixes some of the Lint warnings in android, javaSE, hello sdl java, and hello sdl android projects

CLA

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2020

Codecov Report

Merging #1491 into develop will decrease coverage by 0.02%.
The diff coverage is 47.34%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1491      +/-   ##
=============================================
- Coverage      55.79%   55.76%   -0.03%     
+ Complexity      4950     4945       -5     
=============================================
  Files            515      515              
  Lines          21993    21962      -31     
  Branches        2726     2736      +10     
=============================================
- Hits           12270    12247      -23     
+ Misses          8822     8808      -14     
- Partials         901      907       +6     
Impacted Files Coverage Δ Complexity Δ
...n/java/com/smartdevicelink/encoder/SdlEncoder.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...smartdevicelink/encoder/VirtualDisplayEncoder.java 27.84% <ø> (ø) 8.00 <0.00> (ø)
...tdevicelink/managers/audio/AudioDecoderCompat.java 73.33% <ø> (ø) 3.00 <0.00> (ø)
...artdevicelink/managers/audio/BaseAudioDecoder.java 82.56% <0.00%> (ø) 24.00 <0.00> (ø)
...m/smartdevicelink/managers/audio/SampleBuffer.java 57.50% <ø> (ø) 21.00 <0.00> (ø)
...vicelink/managers/lockscreen/LockScreenConfig.java 91.66% <ø> (ø) 12.00 <0.00> (ø)
...icelink/managers/lockscreen/LockScreenManager.java 41.21% <ø> (ø) 11.00 <0.00> (ø)
...ink/managers/lockscreen/SDLLockScreenActivity.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...icelink/managers/video/HapticInterfaceManager.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/com/smartdevicelink/trace/TraceDeviceInfo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 156 more

@bilal-alsharifi bilal-alsharifi changed the title [WIP] Feature/fix lint warnings [WIP] Fix Lint Warnings Sep 9, 2020
@bilal-alsharifi bilal-alsharifi changed the title [WIP] Fix Lint Warnings Fix Lint Warnings Sep 11, 2020
Comment thread android/sdl_android/src/main/java/com/smartdevicelink/trace/TraceDeviceInfo.java Outdated
Comment thread base/src/main/java/com/smartdevicelink/proxy/RPCStruct.java Outdated
Comment thread base/src/main/java/com/smartdevicelink/transport/SiphonServer.java
@RHenigan RHenigan merged commit 1c0f0a4 into develop Sep 14, 2020
@RHenigan RHenigan deleted the feature/fix_lint_warnings branch September 14, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants