Fix RPCs Mismatches#1494
Merged
JulianKast merged 9 commits intodevelopfrom Sep 16, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1494 +/- ##
=============================================
+ Coverage 55.75% 55.78% +0.02%
- Complexity 4946 5052 +106
=============================================
Files 515 516 +1
Lines 21962 22417 +455
Branches 2736 2838 +102
=============================================
+ Hits 12245 12505 +260
- Misses 8809 8967 +158
- Partials 908 945 +37 |
# Conflicts: # base/src/main/java/com/smartdevicelink/proxy/rpc/SubscribeVehicleDataResponse.java # base/src/main/java/com/smartdevicelink/proxy/rpc/UnsubscribeVehicleDataResponse.java
joeygrover
reviewed
Sep 15, 2020
Member
|
Please make sure to add javadoc to deprecated methods especially if there are new methods that should be used. Also, if you are deprecating a method to replace it, you should call the new method to reduce code redundancy. |
RHenigan
suggested changes
Sep 15, 2020
…s deprecated due to mistake
JulianKast
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1306
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Summary
This PR fixes mismatches in some RPCs between the code in java suite and RPC spec.
CLA