Skip to content

Fix RPCs Mismatches#1494

Merged
JulianKast merged 9 commits intodevelopfrom
feature/fix_rpcs_mismatch
Sep 16, 2020
Merged

Fix RPCs Mismatches#1494
JulianKast merged 9 commits intodevelopfrom
feature/fix_rpcs_mismatch

Conversation

@bilal-alsharifi
Copy link
Copy Markdown
Contributor

@bilal-alsharifi bilal-alsharifi commented Sep 11, 2020

Fixes #1306

This PR is [ready] for review.

Risk

This PR makes [minor] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Summary

This PR fixes mismatches in some RPCs between the code in java suite and RPC spec.

CLA

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2020

Codecov Report

Merging #1494 into develop will increase coverage by 0.02%.
The diff coverage is 79.41%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1494      +/-   ##
=============================================
+ Coverage      55.75%   55.78%   +0.02%     
- Complexity      4946     5052     +106     
=============================================
  Files            515      516       +1     
  Lines          21962    22417     +455     
  Branches        2736     2838     +102     
=============================================
+ Hits           12245    12505     +260     
- Misses          8809     8967     +158     
- Partials         908      945      +37     
Impacted Files Coverage Δ Complexity Δ
...rtdevicelink/proxy/rpc/SeatLocationCapability.java 93.75% <0.00%> (-6.25%) 10.00 <0.00> (ø)
...celink/proxy/rpc/SubscribeVehicleDataResponse.java 95.53% <60.00%> (-1.74%) 69.00 <2.00> (ø)
...link/proxy/rpc/UnsubscribeVehicleDataResponse.java 95.53% <60.00%> (-1.74%) 69.00 <2.00> (ø)
...com/smartdevicelink/proxy/rpc/HMICapabilities.java 50.94% <75.00%> (+1.92%) 15.00 <4.00> (+2.00)
...vicelink/proxy/rpc/ClimateControlCapabilities.java 100.00% <100.00%> (ø) 41.00 <2.00> (+2.00)
...java/com/smartdevicelink/proxy/rpc/TireStatus.java 100.00% <100.00%> (ø) 19.00 <2.00> (+2.00)
...celink/proxy/rpc/UnsubscribeWayPointsResponse.java 100.00% <100.00%> (ø) 5.00 <2.00> (+2.00)
...devicelink/proxy/rpc/VideoStreamingCapability.java 96.42% <100.00%> (+0.27%) 17.00 <4.00> (+2.00)
...smartdevicelink/proxy/rpc/enums/SupportedSeat.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)
...com/smartdevicelink/util/MediaStreamingStatus.java 64.42% <0.00%> (-0.97%) 17.00% <0.00%> (ø%)
... and 7 more

@bilal-alsharifi bilal-alsharifi changed the title [WIP] Fix RPCs Mismatches Fix RPCs Mismatches Sep 14, 2020
# Conflicts:
#	base/src/main/java/com/smartdevicelink/proxy/rpc/SubscribeVehicleDataResponse.java
#	base/src/main/java/com/smartdevicelink/proxy/rpc/UnsubscribeVehicleDataResponse.java
@joeygrover
Copy link
Copy Markdown
Member

Please make sure to add javadoc to deprecated methods especially if there are new methods that should be used. Also, if you are deprecating a method to replace it, you should call the new method to reduce code redundancy.

@JulianKast JulianKast merged commit b5746a4 into develop Sep 16, 2020
@JulianKast JulianKast deleted the feature/fix_rpcs_mismatch branch September 16, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants