Skip to content

Fix some todo comments #1503

Merged
RHenigan merged 2 commits intodevelopfrom
feature/fix_todos
Sep 17, 2020
Merged

Fix some todo comments #1503
RHenigan merged 2 commits intodevelopfrom
feature/fix_todos

Conversation

@bilal-alsharifi
Copy link
Copy Markdown
Contributor

Fixes #1306
This PR is ready for review.

Risk

This PR makes no API changes.

Summary

This PR fixes some todo comments in the library

CLA

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2020

Codecov Report

Merging #1503 into develop will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1503      +/-   ##
=============================================
+ Coverage      55.76%   56.43%   +0.67%     
- Complexity      4957     5098     +141     
=============================================
  Files            515      515              
  Lines          21982    22509     +527     
  Branches        2737     2904     +167     
=============================================
+ Hits           12258    12703     +445     
- Misses          8815     8853      +38     
- Partials         909      953      +44     
Impacted Files Coverage Δ Complexity Δ
...va/com/smartdevicelink/session/BaseSdlSession.java 26.40% <ø> (ø) 13.00 <0.00> (ø)
...tdevicelink/managers/screen/BaseScreenManager.java 67.75% <0.00%> (-0.56%) 71.00% <0.00%> (+23.00%) ⬇️
...icelink/managers/screen/TextsAndGraphicsState.java 100.00% <0.00%> (ø) 24.00% <0.00%> (ø%)
...va/com/smartdevicelink/protocol/BaseSdlPacket.java 72.00% <0.00%> (+2.40%) 27.00% <0.00%> (+2.00%)
...anagers/lifecycle/BaseSystemCapabilityManager.java 71.08% <0.00%> (+4.29%) 66.00% <0.00%> (+12.00%)
...ink/managers/screen/BaseTextAndGraphicManager.java 68.23% <0.00%> (+5.49%) 74.00% <0.00%> (+28.00%)
...managers/screen/TextAndGraphicUpdateOperation.java 79.00% <0.00%> (+6.15%) 164.00% <0.00%> (+75.00%)
...in/java/com/smartdevicelink/proxy/RPCResponse.java 61.29% <0.00%> (+6.45%) 11.00% <0.00%> (+1.00%)

@RHenigan RHenigan merged commit 33d48a4 into develop Sep 17, 2020
@RHenigan RHenigan deleted the feature/fix_todos branch September 17, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants