Skip to content

Make Rpc setters chainable in RPC generator#1525

Merged
RHenigan merged 2 commits intorelease/RC_5.0.0from
RPC-Chainable-Generator
Oct 14, 2020
Merged

Make Rpc setters chainable in RPC generator#1525
RHenigan merged 2 commits intorelease/RC_5.0.0from
RPC-Chainable-Generator

Conversation

@JulianKast
Copy link
Copy Markdown
Contributor

Fixes #1463

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

N/A

Core Tests

Tested using the RPC Generator to make sure it generated structs and functions correctly, as well as making sure setters and chainable.

Summary

Edited function_template.java and struct_template.java to make RPC setters chainable when it generates Rpc's

Changelog

Enhancements
  • RPC generator will now make RPC setters chainable

CLA

@JulianKast JulianKast changed the base branch from master to release/RC_5.0.0 October 9, 2020 19:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2020

Codecov Report

Merging #1525 into release/RC_5.0.0 will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             release/RC_5.0.0    #1525      +/-   ##
======================================================
- Coverage               56.15%   56.14%   -0.02%     
  Complexity               4991     4991              
======================================================
  Files                     515      515              
  Lines                   22272    22272              
  Branches                 2768     2768              
======================================================
- Hits                    12507    12504       -3     
- Misses                   8833     8834       +1     
- Partials                  932      934       +2     
Impacted Files Coverage Δ Complexity Δ
...tdevicelink/managers/audio/AudioDecoderCompat.java 70.00% <0.00%> (-3.34%) 3.00% <0.00%> (ø%)
...com/smartdevicelink/util/MediaStreamingStatus.java 63.80% <0.00%> (-0.96%) 17.00% <0.00%> (ø%)

Copy link
Copy Markdown
Contributor

@RHenigan RHenigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated methods need to "return this;"

@RHenigan RHenigan merged commit d7e54de into release/RC_5.0.0 Oct 14, 2020
@RHenigan RHenigan deleted the RPC-Chainable-Generator branch October 14, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RPC Generator should generate chainable RPCs

2 participants