Make Rpc setters chainable in RPC generator#1525
Merged
RHenigan merged 2 commits intorelease/RC_5.0.0from Oct 14, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/RC_5.0.0 #1525 +/- ##
======================================================
- Coverage 56.15% 56.14% -0.02%
Complexity 4991 4991
======================================================
Files 515 515
Lines 22272 22272
Branches 2768 2768
======================================================
- Hits 12507 12504 -3
- Misses 8833 8834 +1
- Partials 932 934 +2
|
RHenigan
suggested changes
Oct 13, 2020
Contributor
RHenigan
left a comment
There was a problem hiding this comment.
The updated methods need to "return this;"
RHenigan
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1463
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
N/A
Core Tests
Tested using the RPC Generator to make sure it generated structs and functions correctly, as well as making sure setters and chainable.
Summary
Edited
function_template.javaandstruct_template.javato make RPC setters chainable when it generates Rpc'sChangelog
Enhancements
CLA