Fix unit test for Hotfix#1539
Merged
bilal-alsharifi merged 2 commits intohotfix/4.12.1from Oct 26, 2020
Merged
Conversation
…cations need to be made to allow test to work.
JulianKast
changed the title
bilal-alsharifi
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1540
This PR is read for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
ManagerUtilityTests.javaandRPCStructTests.javawere apart of the hotFix, but were developed during 5.0. The test needed to be modified slightly to work with 4.12.1.Changelog
CharacterSet.CID2SETinstead of UsingCharacterSet.UTF_8inManagerUtilityTests.javaimport android.support.test.runner.AndroidJUnit4instead ofimport androidx.test.ext.junit.runners.AndroidJUnit4inManagerUtilityTests.javaandRPCStructTests.javaRPCRequestFactoryTests.javain relation to Lists with initial values of null are not returned properly in RPCs #1473CLA