Fix video streaming incorrect restart#1655
Merged
RHenigan merged 2 commits intorelease/5.1.0_RCfrom Apr 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/5.1.0_RC #1655 +/- ##
======================================================
+ Coverage 54.01% 54.02% +0.01%
- Complexity 5306 5308 +2
======================================================
Files 555 555
Lines 24530 24534 +4
Branches 3093 3095 +2
======================================================
+ Hits 13249 13254 +5
- Misses 10130 10135 +5
+ Partials 1151 1145 -6
|
RHenigan
approved these changes
Apr 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
Added a flag to prevent a listener from being added multiple times and with each time being added, it gets an immediate callback which therefore causes the video stream to stop and restart. This caused issues when the IVI simply displays an alert or dialog over the stream which would move the app to HMI_LIMITED but cause the stream to stop and restart.
Also added a check for null in the remote display class as it was simply just catching the NPE and printing it out in normal logs. It will no longer cause an NPE and exceptions will be logged through the
DebugToolinstead ofLog.Changelog
Bug Fixes
CLA